From: "John W. Linville" <linville@tuxdriver.com>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: Tejun Heo <tj@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitly instead of depending on flush_scheduled_work()
Date: Fri, 15 Oct 2010 15:26:46 -0400 [thread overview]
Message-ID: <20101015192645.GA2438@tuxdriver.com> (raw)
In-Reply-To: <201010151858.45000.chunkeey@googlemail.com>
On Fri, Oct 15, 2010 at 06:58:44PM +0200, Christian Lamparter wrote:
> On Friday 15 October 2010 18:39:37 Tejun Heo wrote:
> > Hello,
>
> > >> - /*
> > >> - * For key todo, it'll be empty by now but the work
> > >> - * might still be scheduled.
> > >> - */
> > >> - flush_scheduled_work();
> > >
> > > oops, todo work no longer exists...
> > >
> > > Anyway, ACK.
> >
> > Are you going to route this through wireless tree? Shall I repost
> > with update patch description?
>
> wireless-testing/wireless-next has already such a patch:
> "mac80211: cancel restart_work in ieee80211_unregister_hw" (2010-08-25)
>
> <http://git.kernel.org/?p=linux/kernel/git/linville/wireless-next-2.6.git;a=commit;h=258086a48b766d12a500f98834654ffa927ca475>
>
> John, can you please push to 2.6.36-rc8?
> (I know, I am _late_, but I didn't know about any potential problem
> in the mainline?)
I don't see how either patch would merit inclusion in 2.6.36 at this point.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-10-15 19:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 15:35 [PATCH v2.6.36-rc7] mac80211: cancel restart_work explicitly instead of depending on flush_scheduled_work() Tejun Heo
2010-10-15 16:21 ` Johannes Berg
2010-10-15 16:39 ` Tejun Heo
2010-10-15 16:58 ` Christian Lamparter
2010-10-15 19:26 ` John W. Linville [this message]
2010-10-15 19:33 ` Tejun Heo
2010-10-15 20:07 ` Christian Lamparter
2010-10-15 20:06 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015192645.GA2438@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=chunkeey@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).