Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Linux-pm mailing list" <linux-pm@lists.linux-foundation.org>,
	linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org
Subject: Re: [PATCH] ath9k: Convert to new PCI PM framework
Date: Sat, 16 Oct 2010 22:02:52 +0200	[thread overview]
Message-ID: <201010162202.52766.rjw@sisk.pl> (raw)
In-Reply-To: <AANLkTimdatos1psRnp_Es=q8iOe9aQE_aVARLpm18efb@mail.gmail.com>

On Saturday, October 16, 2010, Luis R. Rodriguez wrote:
> On Fri, Oct 15, 2010 at 3:36 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > The ath9k driver uses the legacy PCI power management (suspend
> > and resume) callbacks that apparently cause intermittent problems
> > to happen (the adapter sometimes doesn't resume correctly on my
> > Acer Ferrari One).  Make it use the new PCI PM and let the PCI core
> > code handle the PCI-specific details of power transitions.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> 
> Do you know when these hooks were added?

Well, which ones?  If you're asking about the new framework, it's been there
since 2.6.29 and is a recommended way of implementing PM hooks now.

Please have a look at Documentation/power/pci.txt. :-)

> If it fixes an issue should this go for stable?

I'm not 100% sure it fixes everything yet, although I hasn't been able to
reproduce the problem with it applied, so far.

So, I don't think it's -stable material at this point.  However, it should be
done anyway at one point, so it very well can be done right now, given that I
have the hardware to test it. :-)

Thanks,
Rafael

  reply	other threads:[~2010-10-16 20:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15 22:36 [PATCH] ath9k: Convert to new PCI PM framework Rafael J. Wysocki
2010-10-15 23:54 ` Luis R. Rodriguez
2010-10-16 20:02   ` Rafael J. Wysocki [this message]
2010-10-16  1:28 ` Paul Stewart
2010-10-16 19:52   ` Rafael J. Wysocki
2010-12-19 23:32 ` [PATCH] ath9k: Do not use legacy PCI power management Rafael J. Wysocki
2010-12-20  0:05   ` Hauke Mehrtens
2010-12-20  0:14     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010162202.52766.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=ath9k-devel@lists.ath9k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lrodriguez@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox