From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Senthilkumar Balasubramanian <Senthilkumar.Balasubramanian@Atheros.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"stable@kernel.org" <stable@kernel.org>,
Ben Greear <greearb@candelatech.com>,
Kyungwan Nam <Kyungwan.Nam@Atheros.com>
Subject: Re: [PATCH 3/6] ath9k: rename rxflushlock to pcu_lock
Date: Thu, 21 Oct 2010 02:03:32 -0700 [thread overview]
Message-ID: <20101021090332.GD2776@tux> (raw)
In-Reply-To: <20101021070515.GD6948@senthil-lnx.users.atheros.com>
On Thu, Oct 21, 2010 at 12:05:15AM -0700, Senthilkumar Balasubramanian wrote:
> On Thu, Oct 21, 2010 at 11:43:50AM +0530, Luis R. Rodriguez wrote:
> > On Wed, Oct 20, 2010 at 11:03 PM, Senthil Balasubramanian
> > <senthilkumar@atheros.com> wrote:
> > > On Thu, Oct 21, 2010 at 04:37:05AM +0530, Luis R. Rodriguez wrote:
> > >> The real way to lock RX is to contend on the PCU
> > >> and reset, this will be fixed in the next patch but for
> > >> now just do the renames so that the next patch which changes
> > >> the locking order is crystal clear.
> > >>
> > >> This is part of a series that will help resolve the bug:
> > >>
> > >> https://bugzilla.kernel.org/show_bug.cgi?id=14624
> > >>
> > >> For more details about this issue refer to:
> > >>
> > >> http://marc.info/?l=linux-wireless&m=128629803703756&w=2
> > >>
> > >> Cc: stable@kernel.org
> > >> Cc: Ben Greear <greearb@candelatech.com>
> > >> Cc: Kyungwan Nam <kyungwan.nam@atheros.com>
> > >> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > >> ---
> > >> drivers/net/wireless/ath/ath9k/ath9k.h | 2 +-
> > >> drivers/net/wireless/ath/ath9k/main.c | 4 ++--
> > >> drivers/net/wireless/ath/ath9k/recv.c | 6 +++---
> > >> 3 files changed, 6 insertions(+), 6 deletions(-)
> > >>
> > >> diff --git a/drivers/net/wireless/ath/ath9k/ath9k.h b/drivers/net/wireless/ath/ath9k/ath9k.h
> > >> index 0f0bc54..81fed83 100644
> > >> --- a/drivers/net/wireless/ath/ath9k/ath9k.h
> > >> +++ b/drivers/net/wireless/ath/ath9k/ath9k.h
> > >> @@ -309,7 +309,7 @@ struct ath_rx {
> > >> u8 rxotherant;
> > >> u32 *rxlink;
> > >> unsigned int rxfilter;
> > >> - spinlock_t rxflushlock;
> > >> + spinlock_t pcu_lock;
> > >> spinlock_t rxbuflock;
> > >> struct list_head rxbuf;
> > >> struct ath_descdma rxdma;
> > >> diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
> > >> index dcd94ba..37f18ef 100644
> > >> --- a/drivers/net/wireless/ath/ath9k/main.c
> > >> +++ b/drivers/net/wireless/ath/ath9k/main.c
> > >> @@ -609,7 +609,7 @@ void ath9k_tasklet(unsigned long data)
> > >> rxmask = (ATH9K_INT_RX | ATH9K_INT_RXEOL | ATH9K_INT_RXORN);
> > >>
> > >> if (status & rxmask) {
> > >> - spin_lock_bh(&sc->rx.rxflushlock);
> > >> + spin_lock_bh(&sc->rx.pcu_lock);
> > > no need to disable bh as you are already in tasklet. I understand that the
> > > existing code itself was doing this and I thought of fixing that anyway.
> > > Can you plese fix this as well with this patch?
> >
> > Nah, I rather this be a separate patch, which you can test and send yourself :)
> Since we are sending this to stable, I thought we can send a clean patch.
Hrm. Have you tested it?
Luis
next prev parent reply other threads:[~2010-10-21 9:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 23:07 [PATCH 0/6] ath9k: fix RX poison issue Luis R. Rodriguez
2010-10-20 23:07 ` [PATCH 1/6] ath9k: add locking for stopping RX Luis R. Rodriguez
2010-10-20 23:07 ` [PATCH 2/6] ath9k: add locking for starting the PCU on RX Luis R. Rodriguez
2010-10-20 23:07 ` [PATCH 3/6] ath9k: rename rxflushlock to pcu_lock Luis R. Rodriguez
2010-10-21 6:03 ` Senthil Balasubramanian
2010-10-21 6:13 ` Luis R. Rodriguez
2010-10-21 7:05 ` Senthil Balasubramanian
2010-10-21 9:03 ` Luis R. Rodriguez [this message]
2010-10-20 23:07 ` [PATCH 4/6] ath9k: lock reset and PCU start/stopping Luis R. Rodriguez
2010-10-20 23:07 ` [PATCH 5/6] ath: add a ATH_DBG_WARN() Luis R. Rodriguez
2010-10-21 19:14 ` Luis R. Rodriguez
2010-10-20 23:07 ` [PATCH 6/6] ath9k: add a debug warning when we cannot stop RX Luis R. Rodriguez
2010-10-21 17:47 ` [PATCH 0/6] ath9k: fix RX poison issue Ben Greear
2010-10-22 0:30 ` Bruno Randolf
2010-10-22 0:32 ` Luis R. Rodriguez
2010-10-22 4:51 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021090332.GD2776@tux \
--to=lrodriguez@atheros.com \
--cc=Kyungwan.Nam@Atheros.com \
--cc=Luis.Rodriguez@Atheros.com \
--cc=Senthilkumar.Balasubramanian@Atheros.com \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).