From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50955 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756475Ab0JUNLK (ORCPT ); Thu, 21 Oct 2010 09:11:10 -0400 Date: Thu, 21 Oct 2010 15:13:49 +0200 From: Stanislaw Gruszka To: "Guy, Wey-Yi" Cc: Johannes Berg , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH 1/2] iwlwifi: fix set_tx_power vs scan Message-ID: <20101021131348.GA5654@redhat.com> References: <1286977193-12144-1-git-send-email-sgruszka@redhat.com> <1286983100.10446.1.camel@wwguy-ubuntu> <20101014083204.GA2286@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20101014083204.GA2286@redhat.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Oct 14, 2010 at 10:32:05AM +0200, Stanislaw Gruszka wrote: > > Looks good, the only thing is if priv->tx_power_user_lmt == > > priv->tx_power_next, we don't even have to call set_tx_power, but I > > guess calling it won't hurt, so its your decision check or not. > > I'll will call iwl_set_tx_power( ... , false); what seems to be right > thing to do. Set tx power have to be forces. Without that I get iwlagn 0000:40:00.0: low ack count detected, restart firmware iwlagn 0000:40:00.0: On demand firmware reload iwlagn 0000:40:00.0: Stopping AGG while state not ON or starting iwlagn 0000:40:00.0: queue number out of range: 0, must be 10 to 19 iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 0 iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 1 iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 0 iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 0 iwlagn 0000:40:00.0: iwlagn_tx_agg_start on ra = 00:23:69:35:d1:3f tid = 0 iwlagn 0000:40:00.0: low ack count detected, restart firmware iwlagn 0000:40:00.0: On demand firmware reload iwlagn 0000:40:00.0: Stopping AGG while state not ON or starting iwlagn 0000:40:00.0: queue number out of range: 0, must be 10 to 19 iwlagn 0000:40:00.0: iwlagn_tx_agg_start on ra = 00:23:69:35:d1:3f tid = 0 iwlagn 0000:40:00.0: low ack count detected, restart firmware iwlagn 0000:40:00.0: On demand firmware reload iwlagn 0000:40:00.0: Stopping AGG while state not ON or starting iwlagn 0000:40:00.0: queue number out of range: 0, must be 10 to 19 iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 4 iwlagn 0000:40:00.0: Aggregation not enabled for tid 0 because load = 0 on 5300 and device was unusable in general. Hence I will only comment that forcing send tx power after scan is needed. Stanislaw