From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "Guy, Wey-Yi" <wey-yi.w.guy@intel.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 6/7] iwlwifi: defer update power mode while scan
Date: Mon, 25 Oct 2010 10:18:44 +0200 [thread overview]
Message-ID: <20101025081842.GA2343@redhat.com> (raw)
In-Reply-To: <1287761637.8143.3.camel@wwguy-ubuntu>
Hi Wey
On Fri, Oct 22, 2010 at 08:33:57AM -0700, Guy, Wey-Yi wrote:
> On Fri, 2010-10-22 at 08:04 -0700, Stanislaw Gruszka wrote:
> > -int iwl_power_update_mode(struct iwl_priv *priv, bool force)
> > +static void iwl_power_build_cmd(struct iwl_priv *priv,
> > + struct iwl_powertable_cmd *cmd)
> > {
> > - int ret = 0;
> > bool enabled = priv->hw->conf.flags & IEEE80211_CONF_PS;
> > - bool update_chains;
> > - struct iwl_powertable_cmd cmd;
> > int dtimper;
[snip]
> > if (priv->cfg->base_params->broken_powersave)
> > - iwl_power_sleep_cam_cmd(priv, &cmd);
> > + iwl_power_sleep_cam_cmd(priv, cmd);
> Is this right?
Yes, patch change "cmd" to be a pointer anywhere in this function.
Stanislaw
next prev parent reply other threads:[~2010-10-25 8:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 15:04 [PATCH 1/7] iwlwifi: warn when send tx power settings during scan Stanislaw Gruszka
2010-10-22 15:04 ` [PATCH 2/7] iwlwifi: send tx_power_cmd synchronously Stanislaw Gruszka
2010-10-25 14:46 ` Guy, Wey-Yi
2010-10-22 15:04 ` [PATCH 3/7] iwlwifi: fix set_tx_power vs scan Stanislaw Gruszka
2010-10-25 14:47 ` Guy, Wey-Yi
2010-10-22 15:04 ` [PATCH 4/7] iwlwifi: avoid commit rxon during scan in iwlagn_configure_filter Stanislaw Gruszka
2010-10-25 14:47 ` Guy, Wey-Yi
2010-10-22 15:04 ` [PATCH 5/7] iwlwifi: avoid commit rxon during scan in iwlagn_bt_traffic_change_work Stanislaw Gruszka
2010-10-25 14:47 ` Guy, Wey-Yi
2010-10-22 15:04 ` [PATCH 6/7] iwlwifi: defer update power mode while scan Stanislaw Gruszka
2010-10-22 15:33 ` Guy, Wey-Yi
2010-10-25 8:18 ` Stanislaw Gruszka [this message]
2010-10-25 14:47 ` Guy, Wey-Yi
2010-10-22 15:04 ` [PATCH 7/7] iwlwifi: avoid commit rxon during scan in iwl_set_no_assoc Stanislaw Gruszka
2010-10-25 14:48 ` Guy, Wey-Yi
2010-10-22 15:23 ` [PATCH 1/7] iwlwifi: warn when send tx power settings during scan Guy, Wey-Yi
2010-10-25 8:34 ` Stanislaw Gruszka
2010-10-25 14:38 ` Guy, Wey-Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025081842.GA2343@redhat.com \
--to=sgruszka@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).