From: "John W. Linville" <linville@tuxdriver.com>
To: Daniel Drake <dsd@laptop.org>
Cc: linux-wireless@vger.kernel.org, dcbw@redhat.com,
libertas-dev@lists.infradead.org, pgf@laptop.org
Subject: Re: [PATCH v2] libertas: Fix sd8686 firmware reload
Date: Wed, 27 Oct 2010 15:54:27 -0400 [thread overview]
Message-ID: <20101027195427.GB2410@tuxdriver.com> (raw)
In-Reply-To: <20101027142052.9607A9D401B@zog.reactivated.net>
On Wed, Oct 27, 2010 at 03:20:52PM +0100, Daniel Drake wrote:
> From: Paul Fox <pgf@laptop.org>
>
> For the SD8686, we cannot rely on the scratch register to read the firmware
> load status, because the same register is used for storing RX packet length.
> Broaden the check to account for this.
>
> The module can now be unloaded/reloaded successfully.
>
> Based on the implementation from libertas_tf.
>
> Signed-off-by: Daniel Drake <dsd@laptop.org>
CC [M] drivers/net/wireless/libertas/if_sdio.o
drivers/net/wireless/libertas/if_sdio.c: In function ‘if_sdio_prog_firmware’:
drivers/net/wireless/libertas/if_sdio.c:718: error: ‘IF_SDIO_MODEL_8686’ undeclared (first use in this function)
drivers/net/wireless/libertas/if_sdio.c:718: error: (Each undeclared identifier is reported only once
drivers/net/wireless/libertas/if_sdio.c:718: error: for each function it appears in.)
What tree has this definition?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-10-27 20:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 14:20 [PATCH v2] libertas: Fix sd8686 firmware reload Daniel Drake
2010-10-27 19:54 ` John W. Linville [this message]
2010-10-28 5:57 ` Chris Ball
2010-10-28 14:08 ` John W. Linville
2010-10-28 13:50 ` Dan Williams
2010-10-28 13:57 ` Steve deRosier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027195427.GB2410@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=dcbw@redhat.com \
--cc=dsd@laptop.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pgf@laptop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).