From: "John W. Linville" <linville@tuxdriver.com>
To: Ben Greear <greearb@candelatech.com>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net
Subject: Re: [PATCH] ath9k: Clear DMA addresses when buffers are freed.
Date: Fri, 29 Oct 2010 09:21:14 -0400 [thread overview]
Message-ID: <20101029132113.GA2399@tuxdriver.com> (raw)
In-Reply-To: <4CCA0848.7080001@candelatech.com>
On Thu, Oct 28, 2010 at 04:33:28PM -0700, Ben Greear wrote:
> On 10/15/2010 02:29 PM, greearb@candelatech.com wrote:
> >From: Ben Greear<greearb@candelatech.com>
> >
> >Previous patches cleared the pointer to the SKB, but did not
> >clear the DMA addresses. This patch moves the clear logic into
> >a method and makes sure that the DMA addresses are cleared as well.
> >
> >This does not obviously fix any bug, but may make it harder to
> >cause bugs in the future.
>
> I wanted to follow up to see if there was any interest in this patch,
> as it received no comment and has not been accepted upstream.
>
> Thanks,
> Ben
The patch seems fine to me, but it isn't a fix and so isn't going
anywhere until wireless-next-2.6 opens again (i.e. after the merge
window closes).
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2010-10-29 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 21:29 [PATCH] ath9k: Clear DMA addresses when buffers are freed greearb
2010-10-28 23:33 ` Ben Greear
2010-10-28 23:36 ` [ath9k-devel] " Luis R. Rodriguez
2010-10-28 23:44 ` Ben Greear
2010-10-29 13:21 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029132113.GA2399@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).