* [PATCH wireless-2.6] iwlwifi: dont use pci_dev before it being assign
@ 2010-11-09 2:45 Wey-Yi Guy
2010-11-09 19:39 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Wey-Yi Guy @ 2010-11-09 2:45 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, ipw3945-devel, Wey-Yi Guy
In order to use build-in debugging macro, pci_dev in priv need to be
assigned first.
This fix iwl3945 driver oopsed at boot with 2.6.37-rc1
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
---
this patch is also available from wireless-2.6 branch on
git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-2.6.git
drivers/net/wireless/iwlwifi/iwl3945-base.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 193247a..43ff17a 100644
--- a/drivers/net/wireless/iwlwifi/iwl3945-base.c
+++ b/drivers/net/wireless/iwlwifi/iwl3945-base.c
@@ -4003,7 +4003,8 @@ static int iwl3945_pci_probe(struct pci_dev *pdev, const struct pci_device_id *e
* "the hard way", rather than using device's scan.
*/
if (iwl3945_mod_params.disable_hw_scan) {
- IWL_ERR(priv, "sw scan support is deprecated\n");
+ dev_printk(KERN_DEBUG, &(pdev->dev),
+ "sw scan support is deprecated\n");
iwl3945_hw_ops.hw_scan = NULL;
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH wireless-2.6] iwlwifi: dont use pci_dev before it being assign
2010-11-09 2:45 [PATCH wireless-2.6] iwlwifi: dont use pci_dev before it being assign Wey-Yi Guy
@ 2010-11-09 19:39 ` John W. Linville
2010-11-09 20:16 ` Guy, Wey-Yi
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2010-11-09 19:39 UTC (permalink / raw)
To: Wey-Yi Guy; +Cc: linux-wireless, ipw3945-devel
On Mon, Nov 08, 2010 at 06:45:21PM -0800, Wey-Yi Guy wrote:
> In order to use build-in debugging macro, pci_dev in priv need to be
> assigned first.
>
> This fix iwl3945 driver oopsed at boot with 2.6.37-rc1
>
> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> ---
> this patch is also available from wireless-2.6 branch on
> git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-2.6.git
I tried to pull this, but it seemed to be the wrong patch. I manually
applied the posted patch instead.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH wireless-2.6] iwlwifi: dont use pci_dev before it being assign
2010-11-09 19:39 ` John W. Linville
@ 2010-11-09 20:16 ` Guy, Wey-Yi
0 siblings, 0 replies; 3+ messages in thread
From: Guy, Wey-Yi @ 2010-11-09 20:16 UTC (permalink / raw)
To: John W. Linville
Cc: linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net
Hi John,
On Tue, 2010-11-09 at 11:39 -0800, John W. Linville wrote:
> On Mon, Nov 08, 2010 at 06:45:21PM -0800, Wey-Yi Guy wrote:
> > In order to use build-in debugging macro, pci_dev in priv need to be
> > assigned first.
> >
> > This fix iwl3945 driver oopsed at boot with 2.6.37-rc1
> >
> > Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> > ---
> > this patch is also available from wireless-2.6 branch on
> > git://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-2.6.git
>
> I tried to pull this, but it seemed to be the wrong patch. I manually
> applied the posted patch instead.
>
Thanks so much, this patch is really needed.
Wey
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-09 20:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-09 2:45 [PATCH wireless-2.6] iwlwifi: dont use pci_dev before it being assign Wey-Yi Guy
2010-11-09 19:39 ` John W. Linville
2010-11-09 20:16 ` Guy, Wey-Yi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).