From: Christian Lamparter <chunkeey@googlemail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org,
Andreas Herrmann <andreas.herrmann3@amd.com>
Subject: Re: [PATCH 2/6] carl9170: use generic sign_extend32
Date: Wed, 10 Nov 2010 21:21:49 +0100 [thread overview]
Message-ID: <201011102121.50082.chunkeey@googlemail.com> (raw)
In-Reply-To: <20101110200635.GF2714@tuxdriver.com>
On Wednesday 10 November 2010 21:06:36 John W. Linville wrote:
> On Fri, Oct 29, 2010 at 11:11:23PM +0200, Christian Lamparter wrote:
> > This patch replaces the handcrafted
> > sign extension cruft with a generic
> > bitop function.
> >
> > Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
>
> CC [M] drivers/net/wireless/ath/carl9170/phy.o
> drivers/net/wireless/ath/carl9170/phy.c: In function ‘carl9170_get_noisefloor’:
> drivers/net/wireless/ath/carl9170/phy.c:1572: error: implicit declaration of function ‘sign_extend32’
> make[3]: *** [drivers/net/wireless/ath/carl9170/phy.o] Error 1
> make[2]: *** [drivers/net/wireless/ath/carl9170] Error 2
> make[1]: *** [drivers/net/wireless/ath] Error 2
> make: *** [drivers/net/wireless/] Error 2
>
> Maybe we should wait until this function exists before we use it? :-)
interesting,
https://patchwork.kernel.org/patch/143241/
so why exactly wasn't this patch merged?
Regards,
Chr
next prev parent reply other threads:[~2010-11-10 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 23:10 [PATCH 0/6] carl9170: 2.6.38 patches Christian Lamparter
2010-10-29 20:44 ` [PATCH 1/6] carl9170: import hw/fw header updates Christian Lamparter
2010-10-29 21:11 ` [PATCH 2/6] carl9170: use generic sign_extend32 Christian Lamparter
2010-11-10 20:06 ` John W. Linville
2010-11-10 20:21 ` Christian Lamparter [this message]
2010-11-10 20:43 ` John W. Linville
2010-10-29 21:17 ` [PATCH 3/6] carl9170: initialize HW aMPDU parameters properly Christian Lamparter
2010-10-29 21:26 ` [PATCH 4/6] carl9170: fix spurious restart due to high latency Christian Lamparter
2010-10-29 21:41 ` [PATCH 5/6] carl9170: stop stale uplink BA sessions Christian Lamparter
2010-10-29 22:36 ` [PATCH 6/6] carl9170: configurable beacon rates Christian Lamparter
2010-10-29 22:49 ` [RFT] carl9170: improve rx ampdu software deaggregation Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011102121.50082.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=andreas.herrmann3@amd.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).