Re: iwlwifi: fix modular legacy build errors

["John W. Linville" <linville@tuxdriver.com>]

On Thu, Nov 18, 2010 at 09:36:00AM -0800, Guy, Wey-Yi wrote:
> John,
> 
> On Thu, 2010-11-18 at 09:11 -0800, Randy Dunlap wrote:
> > On Wed, 17 Nov 2010 09:11:16 -0800 Guy, Wey-Yi wrote:
> > 
> > > Hi Randy,
> > > 
> > > On Wed, 2010-11-17 at 09:12 -0800, Randy Dunlap wrote:
> > > > On 11/17/10 08:49, Johannes Berg wrote:
> > > > > On Wed, 2010-11-17 at 08:36 -0800, Guy, Wey-Yi wrote:
> > > > >> Hi Randy,
> > > > >>
> > > > >> the "iwlwifi: fix modular legacy build errors" patch cause the following
> > > > >> WARNING when compile 
> > > > > 
> > > > > I thought we already had had a fix for that issue anyway?
> > > > 
> > > > Not that I know of.  I reported a different build error and
> > > > included a patch, which is now causing problems, so I asked
> > > > John to drop/revert my patch.
> > > > 
> > > > Here is part of the patch description that I sent:
> > > > 
> > > > 
> > > > With CONFIG_IWLWIFI=m, CONFIG_IWLAGN=m, and CONFIG_IWL3945=m,
> > > > a kernel build has errors as below.  Changing a few lines in the
> > > > Makefile is one possible fix for these build errors.
> > > > 
> > > > ERROR: "iwl_legacy_mac_config" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined!
> > > > ERROR: "iwl_isr_legacy" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined!
> > > > ERROR: "iwl_legacy_tx_cmd_protection" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined!
> > > > ERROR: "iwl_legacy_mac_bss_info_changed" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined!
> > > > ERROR: "iwl_legacy_mac_reset_tsf" [drivers/net/wireless/iwlwifi/iwl3945.ko] undefined!
> > > > 
> > > > 
> > > > So John can revert my patch and then let the iwlwifi maintainers fix this problem,
> > > > please.
> > > > 
> > > 
> > > "iwlagn: fix non-5000+ build" send by Johannes should have this problem
> > > addressed.
> > 
> > 
> > Can we get this patch into linux-next, please?
> > linux-next of 2010.1118 is still having these build errors.
> > 
> 
> Could you help?

It's in wireless-next-2.6 already.  Has linux-next stopped pulling that?

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.