* [RFC] mac80211: disable aggregatin for voice traffic
@ 2010-11-19 1:18 Luis R. Rodriguez
2010-11-19 1:21 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: Luis R. Rodriguez @ 2010-11-19 1:18 UTC (permalink / raw)
To: johannes
Cc: linux-wireless, Luis R. Rodriguez, Matt Smith,
Senthil Balasubramanian
This should help with latency issues which can happen when
using aggregation.
Cc: Matt Smith <matt.smith@atheros.com>
Cc: Senthil Balasubramanian <senthilkumar@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
We discussed this a while ago but never to around to it.
net/mac80211/tx.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index e694836..405ddc9 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1225,7 +1225,8 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data *sdata,
tx->sta = sta_info_get(sdata, hdr->addr1);
if (tx->sta && ieee80211_is_data_qos(hdr->frame_control) &&
- (local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION)) {
+ (local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION) &&
+ (ieee802_1d_to_ac[skb->priority] != IEEE80211_AC_VO)) {
struct tid_ampdu_tx *tid_tx;
qc = ieee80211_get_qos_ctl(hdr);
--
1.7.3.2.90.gd4c43
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC] mac80211: disable aggregatin for voice traffic
2010-11-19 1:18 [RFC] mac80211: disable aggregatin for voice traffic Luis R. Rodriguez
@ 2010-11-19 1:21 ` Johannes Berg
2010-11-19 1:23 ` Luis R. Rodriguez
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2010-11-19 1:21 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linux-wireless, Matt Smith, Senthil Balasubramanian
On Thu, 18 Nov 2010 17:18:54 -0800, "Luis R. Rodriguez"
<lrodriguez@atheros.com> wrote:
> This should help with latency issues which can happen when
> using aggregation.
>
> Cc: Matt Smith <matt.smith@atheros.com>
> Cc: Senthil Balasubramanian <senthilkumar@atheros.com>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
>
> We discussed this a while ago but never to around to it.
>
> net/mac80211/tx.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index e694836..405ddc9 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -1225,7 +1225,8 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data
> *sdata,
> tx->sta = sta_info_get(sdata, hdr->addr1);
>
> if (tx->sta && ieee80211_is_data_qos(hdr->frame_control) &&
> - (local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION)) {
> + (local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION) &&
> + (ieee802_1d_to_ac[skb->priority] != IEEE80211_AC_VO)) {
wtf? total NACK. You're setting up an aggregation session and then not
using it? That's totally deluded ... just don't set up the session!!
johannes
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] mac80211: disable aggregatin for voice traffic
2010-11-19 1:21 ` Johannes Berg
@ 2010-11-19 1:23 ` Luis R. Rodriguez
0 siblings, 0 replies; 3+ messages in thread
From: Luis R. Rodriguez @ 2010-11-19 1:23 UTC (permalink / raw)
To: Johannes Berg
Cc: Luis Rodriguez, linux-wireless@vger.kernel.org, Matt Smith,
Senthilkumar Balasubramanian
On Thu, Nov 18, 2010 at 05:21:24PM -0800, Johannes Berg wrote:
> On Thu, 18 Nov 2010 17:18:54 -0800, "Luis R. Rodriguez"
> <lrodriguez@atheros.com> wrote:
> > This should help with latency issues which can happen when
> > using aggregation.
> >
> > Cc: Matt Smith <matt.smith@atheros.com>
> > Cc: Senthil Balasubramanian <senthilkumar@atheros.com>
> > Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> > ---
> >
> > We discussed this a while ago but never to around to it.
> >
> > net/mac80211/tx.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> > index e694836..405ddc9 100644
> > --- a/net/mac80211/tx.c
> > +++ b/net/mac80211/tx.c
> > @@ -1225,7 +1225,8 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data
> > *sdata,
> > tx->sta = sta_info_get(sdata, hdr->addr1);
> >
> > if (tx->sta && ieee80211_is_data_qos(hdr->frame_control) &&
> > - (local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION)) {
> > + (local->hw.flags & IEEE80211_HW_AMPDU_AGGREGATION) &&
> > + (ieee802_1d_to_ac[skb->priority] != IEEE80211_AC_VO)) {
>
> wtf? total NACK. You're setting up an aggregation session and then not
> using it? That's totally deluded ... just don't set up the session!!
:) thanks for the kind review.
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-19 1:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-19 1:18 [RFC] mac80211: disable aggregatin for voice traffic Luis R. Rodriguez
2010-11-19 1:21 ` Johannes Berg
2010-11-19 1:23 ` Luis R. Rodriguez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).