From: Christian Lamparter <chunkeey@googlemail.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: Rajkumar Manoharan <rmanoharan@atheros.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] ath: Add a driver_info bitmask field
Date: Mon, 22 Nov 2010 22:33:30 +0100 [thread overview]
Message-ID: <201011222233.31346.chunkeey@googlemail.com> (raw)
In-Reply-To: <AANLkTimTGAr5aA-CkuvezH4FXTs2SD4MnYTmWo7Ru44p@mail.gmail.com>
On Monday 22 November 2010 22:23:36 Bob Copeland wrote:
> On Fri, Nov 19, 2010 at 6:23 AM, Rajkumar Manoharan
> <rmanoharan@atheros.com> wrote:
> > The driver_info stores the device category information which
> > is used to load appropriate device firmware, select firmware offset
> > and eeprom starting location. The driver_info is accessed across
> > ath9k_htc and ath9k_hw. Hence placed under common structure.
>
> > /**
> > * struct ath_ops - Register read/write operations
> > *
> > @@ -147,6 +152,7 @@ struct ath_common {
> > u8 rx_chainmask;
> >
> > u32 rx_bufsize;
> > + u32 driver_info;
>
>
> u32 for 2 bits?
well, if you take in account that mod_devicetable.h specifies
driver_info to be kernel_ulong_t... (to store pointers of course)
I would say we need "even" more.
Best regards,
Chr
next prev parent reply other threads:[~2010-11-22 21:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 11:23 [PATCH 1/4] ath: Add a driver_info bitmask field Rajkumar Manoharan
2010-11-19 11:23 ` [PATCH 2/4] ath9k_htc: Add driver_info in usb device list Rajkumar Manoharan
2010-11-19 11:23 ` [PATCH 3/4] ath9k_hw: Fix eeprom offset for AR9287 devices (PCI/USB) Rajkumar Manoharan
2010-11-19 11:23 ` [PATCH 4/4] ath9k_htc: Identify devices using driver_info Rajkumar Manoharan
2010-11-22 21:23 ` [PATCH 1/4] ath: Add a driver_info bitmask field Bob Copeland
2010-11-22 21:33 ` Christian Lamparter [this message]
2010-11-23 5:35 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011222233.31346.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
--cc=rmanoharan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).