From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] iwlwifi: avoid "Error sending TX power (-5)"
Date: Wed, 24 Nov 2010 15:11:33 +0100 [thread overview]
Message-ID: <20101124141133.GA2983@redhat.com> (raw)
In-Reply-To: <20101124130403.GA2446@redhat.com>
On Wed, Nov 24, 2010 at 02:04:03PM +0100, Stanislaw Gruszka wrote:
> On Wed, Nov 24, 2010 at 11:44:12AM +0100, Johannes Berg wrote:
> > On Wed, 2010-11-24 at 11:37 +0100, Stanislaw Gruszka wrote:
> > > We can have this error message when loading or unloading module, when
> > > device is not marked as ready, but we want to set tx power from
> > > commit_rxon. Perhaps something better should be done like call
> > > lib->send_tx_power() directly from commit_rxon, but for now just
> > > do not return error.
> >
> > I think this actually fixes it, as opposed to hiding it:
> >
> > http://git.kernel.org/?p=linux/kernel/git/iwlwifi/iwlwifi-2.6.git;a=commitdiff;h=9e2e7422d059f9b98c3a0810df92a1ff660ade2f
>
> Yes.
Not fully, message disappears at start, but not when module
is unloaded.
Stanislaw
next prev parent reply other threads:[~2010-11-24 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 10:37 [PATCH] iwlwifi: avoid "Error sending TX power (-5)" Stanislaw Gruszka
2010-11-24 10:44 ` Johannes Berg
2010-11-24 13:04 ` Stanislaw Gruszka
2010-11-24 14:11 ` Stanislaw Gruszka [this message]
2010-11-24 15:41 ` Guy, Wey-Yi
2010-11-25 12:00 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124141133.GA2983@redhat.com \
--to=sgruszka@redhat.com \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).