Re: [ath5k-devel] [PATCH 16/30] ath5k: Set all IFS intervals, not just slot time

["Lukáš Turek" <8an@praha12.net>]

[-- Attachment #1: Type: Text/Plain, Size: 1062 bytes --]

On Saturday 27 November 2010 02:31:53 Nick Kossifidis wrote:
> When we convert to core clock units it's what we should do, all
> timings should change the same way. I don't know what this
> aPHY-RX-START-Delay is but if it changes that way we can use absolute
> values as we do for slot time and sifs.

Although aPHY-RX-START-Delay is specified in the standard, it's not needed on 
Atheros hardware, probably the hardware starts the timeout countdown after it 
switches to RX mode (so aPHY-RX-START-Delay is added implicitly). See my 
discussion with Felix Fietkau a year ago, starting here:
http://www.mail-archive.com/ath5k-devel@lists.ath5k.org/msg02810.html

The calculation used in set_coverage_class is also the same as the one in 
Madwifi driver. When I wrote that code, I intentionally kept the old initvals 
when no coverage class was set to prevent regressions (the ACK timeout in 
initivals is larger than the one for coverage class 0, so a long distance link 
that worked before would break). Maybe I was too careful.

Lukas Turek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]