From: Johannes Stezenbach <js@sig21.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Ivo van Doorn <IvDoorn@gmail.com>,
Gertjan van Wingerde <gwingerde@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
Helmut Schaa <helmut.schaa@googlemail.com>
Subject: Re: [PATCH v4] mac80211/rt2x00: add ieee80211_tx_status_ni()
Date: Tue, 30 Nov 2010 17:34:57 +0100 [thread overview]
Message-ID: <20101130163457.GA4647@sig21.net> (raw)
In-Reply-To: <1291132380.3624.22.camel@jlt3.sipsolutions.net>
On Tue, Nov 30, 2010 at 04:53:00PM +0100, Johannes Berg wrote:
> On Tue, 2010-11-30 at 16:49 +0100, Johannes Stezenbach wrote:
>
> > * This function may not be called in IRQ context. Calls to this function
> > * for a single hardware must be synchronized against each other. Calls
> > - * to this function and ieee80211_tx_status_irqsafe() may not be mixed
> > - * for a single hardware.
> > + * to this function, ieee80211_tx_status_ni() and ieee80211_tx_status_irqsafe()
> > + * may not be mixed for a single hardware.
>
> I'm ok with this, although technically you can mix
> ieee80211_tx_status_ni() and ieee80211_tx_status(), just not either or
> both of them with _irqsafe().
I copied these from ieee80211_rx() etc. since I wasn't sure if there's
not some subtlety I didn't get. One can mix ieee80211_rx() and
ieee80211_rx_ni(), too, right?
Thanks
Johannes
next prev parent reply other threads:[~2010-11-30 16:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 14:54 [PATCH RFC] mac80211: fix "NOHZ: local_softirq_pending 08" Johannes Stezenbach
2010-11-29 15:09 ` Johannes Berg
2010-11-29 15:27 ` Johannes Stezenbach
2010-11-29 15:37 ` Johannes Berg
2010-11-29 15:51 ` [PATCH v2 " Johannes Stezenbach
2010-11-29 15:58 ` Johannes Berg
2010-11-29 16:13 ` [PATCH v3 RFC] mac80211: add ieee80211_tx_status_ni() Johannes Stezenbach
2010-11-30 15:49 ` [PATCH v4] mac80211/rt2x00: " Johannes Stezenbach
2010-11-30 15:53 ` Johannes Berg
2010-11-30 16:34 ` Johannes Stezenbach [this message]
2010-11-30 16:35 ` Johannes Berg
2010-11-30 18:38 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130163457.GA4647@sig21.net \
--to=js@sig21.net \
--cc=IvDoorn@gmail.com \
--cc=gwingerde@gmail.com \
--cc=helmut.schaa@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).