From: "John W. Linville" <linville@tuxdriver.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, lrodriguez@atheros.com
Subject: Re: [PATCH 2.6.37 v2 1/2] ath9k_hw: fix endian issues with CTLs on AR9003
Date: Tue, 30 Nov 2010 13:27:16 -0500 [thread overview]
Message-ID: <20101130182715.GD2341@tuxdriver.com> (raw)
In-Reply-To: <1291131338-93870-1-git-send-email-nbd@openwrt.org>
On Tue, Nov 30, 2010 at 04:35:37PM +0100, Felix Fietkau wrote:
> Parsing data using bitfields is messy, because it makes endian handling
> much harder. AR9002 and earlier got it right, AR9003 got it wrong.
> This might lead to either using too high or too low tx power values,
> depending on frequency and eeprom settings.
> Fix it by getting rid of the CTL related bitfields entirely and use
> masks instead.
>
> Signed-off-by: Felix Fietkau <nbd@openwrt.org>
> Cc: stable@kernel.org
> ---
> drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 314 ++++++++++++------------
> drivers/net/wireless/ath/ath9k/ar9003_eeprom.h | 9 +-
> drivers/net/wireless/ath/ath9k/eeprom.c | 6 +-
> drivers/net/wireless/ath/ath9k/eeprom.h | 13 +-
> 4 files changed, 167 insertions(+), 175 deletions(-)
patching file drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
Hunk #1 FAILED at 57.
Hunk #2 FAILED at 296.
Hunk #3 succeeded at 568 (offset -14 lines).
Hunk #4 FAILED at 873.
Hunk #5 FAILED at 1159.
Hunk #6 FAILED at 1451.
Hunk #7 FAILED at 1737.
Hunk #8 FAILED at 2029.
Hunk #9 FAILED at 2315.
Hunk #10 FAILED at 2606.
Hunk #11 FAILED at 2892.
Hunk #12 succeeded at 1827 (offset -2536 lines).
Hunk #13 succeeded at 1847 (offset -2536 lines).
10 out of 13 hunks FAILED -- saving rejects to file drivers/net/wireless/ath/ath9k/ar9003_eeprom.c.rej
patching file drivers/net/wireless/ath/ath9k/ar9003_eeprom.h
Hunk #1 succeeded at 261 with fuzz 1 (offset -9 lines).
patching file drivers/net/wireless/ath/ath9k/eeprom.c
patching file drivers/net/wireless/ath/ath9k/eeprom.h
Please base the patch against this tree:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git
Thanks,
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-11-30 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 15:35 [PATCH 2.6.37 v2 1/2] ath9k_hw: fix endian issues with CTLs on AR9003 Felix Fietkau
2010-11-30 15:35 ` [PATCH 2.6.37 v2 2/2] ath9k_hw: fix more bitfield related endian issues Felix Fietkau
2010-11-30 18:27 ` John W. Linville [this message]
2010-11-30 18:46 ` [PATCH 2.6.37 v2 1/2] ath9k_hw: fix endian issues with CTLs on AR9003 Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130182715.GD2341@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).