From: Helmut Schaa <helmut.schaa@googlemail.com>
To: Mohammed Shafi <shafi.wireless@gmail.com>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] mac80211: Update last_tx_rate only for data frames
Date: Wed, 1 Dec 2010 16:14:06 +0100 [thread overview]
Message-ID: <201012011614.07163.helmut.schaa@googlemail.com> (raw)
In-Reply-To: <201012011540.45031.helmut.schaa@googlemail.com>
Am Mittwoch 01 Dezember 2010 schrieb Helmut Schaa:
> Am Mittwoch 01 Dezember 2010 schrieb Mohammed Shafi:
> > On Wed, Dec 1, 2010 at 4:48 PM, Helmut Schaa
> > <helmut.schaa@googlemail.com> wrote:
> > > The last_tx_rate field was also updated for non-data frames that are
> > > often sent with a lower rate (for example management frames at 1 Mbps).
> > > This is confusing when the data rate is actually much higher.
> > >
> > > Hence, only update the last_tx_rate field with tx rate information
> > > gathered from the last data frames.
> >
> > Hi Helmut,
> > I have a doubt,ideally should not this be taken care by the driver ?
>
> Sorry, I don't get your point. How should that be handled by the driver? Could
> you please elaborate?
Ahh, did you mean that should be taken care of by the rate control algorithm?
I agree, if the rate control algortihm returns a rate via txrc.reported_rate
we should just use that without further validation.
Nevertheless, if the rate control algortihm doesn't fill in txrc.reported_rate
we should only account data frames.
Will send an updated patch.
Helmut
next prev parent reply other threads:[~2010-12-01 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 11:18 [PATCH] mac80211: Update last_tx_rate only for data frames Helmut Schaa
2010-12-01 14:04 ` Mohammed Shafi
2010-12-01 14:40 ` Helmut Schaa
2010-12-01 15:03 ` Mohammed Shafi
2010-12-01 15:14 ` Helmut Schaa [this message]
2010-12-01 15:21 ` Mohammed Shafi
2010-12-01 16:54 ` Larry Finger
2010-12-01 15:34 ` [PATCHv2] " Helmut Schaa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012011614.07163.helmut.schaa@googlemail.com \
--to=helmut.schaa@googlemail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=shafi.wireless@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).