From: "John W. Linville" <linville@tuxdriver.com>
To: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
Cc: linux-wireless@vger.kernel.org, lrodriguez@atheros.com
Subject: Re: [PATCH] ath9k: Properly use unlikely check macro
Date: Thu, 2 Dec 2010 15:21:28 -0500 [thread overview]
Message-ID: <20101202202127.GF2358@tuxdriver.com> (raw)
In-Reply-To: <1291044477-2317-1-git-send-email-mshajakhan@atheros.com>
On Mon, Nov 29, 2010 at 08:57:57PM +0530, Mohammed Shafi Shajakhan wrote:
> From: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
>
> AUTOSLEEP feature is enabled only AR9003 and later chips.So unlikely
> macro should be used only to check whether auto-sleep feature is enabled
>
> Signed-off-by: Mohammed Shafi Shajakhan <mshajakhan@atheros.com>
> ---
> drivers/net/wireless/ath/ath9k/recv.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/recv.c b/drivers/net/wireless/ath/ath9k/recv.c
> index 262c815..751ee1b 100644
> --- a/drivers/net/wireless/ath/ath9k/recv.c
> +++ b/drivers/net/wireless/ath/ath9k/recv.c
> @@ -1743,10 +1743,10 @@ int ath_rx_tasklet(struct ath_softc *sc, int flush, bool hp)
> }
>
> spin_lock_irqsave(&sc->sc_pm_lock, flags);
> - if (unlikely(ath9k_check_auto_sleep(sc) ||
> - (sc->ps_flags & (PS_WAIT_FOR_BEACON |
> + if ((sc->ps_flags & (PS_WAIT_FOR_BEACON |
> PS_WAIT_FOR_CAB |
> - PS_WAIT_FOR_PSPOLL_DATA))))
> + PS_WAIT_FOR_PSPOLL_DATA)) ||
> + unlikely(ath9k_hw_check_auto_sleep(sc)))
> ath_rx_ps(sc, skb);
> spin_unlock_irqrestore(&sc->sc_pm_lock, flags);
What tree is this against?
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-12-02 20:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 15:27 [PATCH] ath9k: Properly use unlikely check macro Mohammed Shafi Shajakhan
2010-12-02 20:21 ` John W. Linville [this message]
2010-12-03 4:44 ` Mohammed Shafi
2010-12-03 14:59 ` John W. Linville
2010-12-03 15:08 ` Mohammed Shafi
2010-12-03 15:24 ` Mohammed Shafi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202202127.GF2358@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mshajakhan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).