From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: ath5k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org,
me@bobcopeland.com, jirislaby@gmail.com, nbd@openwrt.org,
br1@einfach.org, sedat.dilek@googlemail.com
Subject: Re: [PATCH 5/6] ath5k: Update version string
Date: Fri, 3 Dec 2010 09:56:55 -0500 [thread overview]
Message-ID: <20101203145654.GB2348@tuxdriver.com> (raw)
In-Reply-To: <AANLkTi=n0wkMTWxJvvNHHMyjvGA25JSr8awWKMJsAv+g@mail.gmail.com>
On Thu, Dec 02, 2010 at 08:17:41PM -0800, Luis R. Rodriguez wrote:
> On Thu, Dec 2, 2010 at 8:11 PM, Nick Kossifidis <mickflemm@gmail.com> wrote:
> > * Change version number, we've added various new features lately.
> > We need to find a way to maintain this, maybe on each kernel release
> > or something. Also remove "EXPERIMENTAL", we aren't experimental any
> > more I think ;-)
> >
> > Signed-off-by: Nick Kossifidis <mickflemm@gmail.com>
>
> > +MODULE_VERSION("0.7.0");
>
> How about just remove this all together, the version should go by the
> kernel or git describe.
ACK -- any objections?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-12-03 15:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 4:11 [PATCH 5/6] ath5k: Update version string Nick Kossifidis
2010-12-03 4:17 ` Luis R. Rodriguez
2010-12-03 14:56 ` John W. Linville [this message]
2010-12-06 23:54 ` Nick Kossifidis
2010-12-03 6:35 ` Sedat Dilek
2010-12-03 7:23 ` Sedat Dilek
2010-12-07 19:13 ` [PATCH] ath5k: remove MODULE_VERSION John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203145654.GB2348@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=br1@einfach.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=me@bobcopeland.com \
--cc=nbd@openwrt.org \
--cc=sedat.dilek@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox