From: Bruno Randolf <br1@einfach.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/3] nl80211: Export available antennas
Date: Mon, 6 Dec 2010 17:30:16 +0900 [thread overview]
Message-ID: <201012061730.16102.br1@einfach.org> (raw)
In-Reply-To: <1291623453.3506.1.camel@jlt3.sipsolutions.net>
On Mon December 6 2010 17:17:33 Johannes Berg wrote:
> On Mon, 2010-12-06 at 12:45 +0900, Bruno Randolf wrote:
> > + NLA_PUT_U32(msg, NL80211_ATTR_WIPHY_ANTENNA_AVAIL,
> > + dev->wiphy.available_antennas);
>
> I think you should not advertise this unless it's non-zero, and unless
> also the set/get callbacks are available.
I don't. Please check the context of this patch, esp patch 1. of this series.
> Similarly, I think you shouldn't advertise the set/get CMDs when the
> available antennas aren't set.
There are no set/get commands for antennas since you preferred putting it into
wiphy info.
> Finally, you should check for nl80211 that the given tx/rx masks fall
> into the available antennas mask.
Allright, I can do that. Would you prefer to reject the command in this case
or just apply the available mask?
bruno
next prev parent reply other threads:[~2010-12-06 8:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 3:45 [PATCH 1/3] cfg80211: Add antenna availability information Bruno Randolf
2010-12-06 3:45 ` [PATCH 2/3] nl80211: Export available antennas Bruno Randolf
2010-12-06 8:17 ` Johannes Berg
2010-12-06 8:30 ` Bruno Randolf [this message]
2010-12-06 8:33 ` Johannes Berg
2010-12-07 2:17 ` Bruno Randolf
2010-12-07 9:35 ` Johannes Berg
2010-12-08 3:45 ` Bruno Randolf
2010-12-06 3:45 ` [PATCH 3/3] ath5k: Set available antenna information for cfg80211 Bruno Randolf
-- strict thread matches above, loose matches on Subject: below --
2010-12-16 2:30 [PATCH 1/3] cfg80211: Separate available antennas for RX and TX Bruno Randolf
2010-12-16 2:30 ` [PATCH 2/3] nl80211: Export available antennas Bruno Randolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012061730.16102.br1@einfach.org \
--to=br1@einfach.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).