From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Ben Greear <greearb@candelatech.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
"greearb@gmail.com" <greearb@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath9k-devel@venema.h4ckr.net" <ath9k-devel@venema.h4ckr.net>
Subject: Re: [PATCH] ath9k: Check for NULL sta in ath_tx_start
Date: Tue, 7 Dec 2010 13:12:37 +0530 [thread overview]
Message-ID: <20101207074237.GA2179@vasanth-laptop> (raw)
In-Reply-To: <4CFDC7D8.3080100@candelatech.com>
On Tue, Dec 07, 2010 at 11:06:24AM +0530, Ben Greear wrote:
> On 12/06/2010 09:21 PM, Luis R. Rodriguez wrote:
> > On Mon, Dec 6, 2010 at 9:13 PM,<greearb@gmail.com> wrote:
> >> From: Ben Greear<greearb@candelatech.com>
> >>
> >> It can be NULL according to docs, and logging showed it
> >> to be NULL in practice.
> >>
> >> Signed-off-by: Ben Greear<greearb@candelatech.com>
> >
> > Does this fix an oops? If so can you explain and provide the trace and
> > resubmit and cc stable in the commit log?
>
> I think it fixes the TID corruption I posted about earlier. It seems
> so obvious though, that I'm curious why no one else sees problems,
> and why I didn't see more crashes in my setup.
>
> (The paprd code appears to send with null STA, for instance, and my
> printks showed lots of NULL stas in my 16-sta test setup, though I
> don't think I'm using the paprd code path.)
paprd is used only with >= AR9003.
Vasanth
next prev parent reply other threads:[~2010-12-07 7:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 5:13 [PATCH] ath9k: Check for NULL sta in ath_tx_start greearb
2010-12-07 5:21 ` Luis R. Rodriguez
2010-12-07 5:36 ` Ben Greear
2010-12-07 7:42 ` Vasanthakumar Thiagarajan [this message]
2010-12-07 7:49 ` Ben Greear
2010-12-07 8:31 ` Vasanthakumar Thiagarajan
2010-12-07 17:13 ` Ben Greear
2010-12-08 5:17 ` Vasanthakumar Thiagarajan
2010-12-08 15:40 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207074237.GA2179@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=ath9k-devel@venema.h4ckr.net \
--cc=greearb@candelatech.com \
--cc=greearb@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).