Re: [ath5k-devel] ath5k: Weird Retransmission Behaviour

[Bruno Randolf <br1@einfach.org>]

On Mon December 6 2010 19:53:49 Sedat Dilek wrote:
> >> But it seems weird that there are so many retransmissions. The default
> >> maximum numbers of retransmissions should be 7 for short frames and 4
> >> for long frames (dot11[Short|Long]RetryLimit), and this is what is set
> >> as defaults in mac80211 (local->hw.conf.short_frame_max_tx_count).
> >> Seems we are getting many
> > 
> >> retransmissions from minstel, i added some debug prints:
> > When ath5k doesn't get retry limits from above it uses the following
> > defaults on dcu.
> > For now i don't think we use local->hw.conf.short_frame_max_tx_count
> > for that so the
> > default is ah_limit_tx_retries (AR5K_INIT_TX_RETRY) but seems it's
> > wrong and we should
> > fix it...
> > 
> > /* Tx retry limits */
> > #define AR5K_INIT_SH_RETRY                      10
> > #define AR5K_INIT_LG_RETRY                      AR5K_INIT_SH_RETRY
> > /* For station mode */
> > #define AR5K_INIT_SSH_RETRY                     32
> > #define AR5K_INIT_SLG_RETRY                     AR5K_INIT_SSH_RETRY
> > #define AR5K_INIT_TX_RETRY                      10

> You mean sth. like the attached patch?

Not quite. We should get the values from mac80211 and use them.

At least this does explain the resetting of the contention window after 10.

bruno