From: "John W. Linville" <linville@tuxdriver.com>
To: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Cc: linux-wireless@vger.kernel.org,
ipw3945-devel@lists.sourceforge.net,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH 2/3] iwlagn: implement layout-agnostic EEPROM reading
Date: Tue, 7 Dec 2010 14:28:06 -0500 [thread overview]
Message-ID: <20101207192806.GF2700@tuxdriver.com> (raw)
In-Reply-To: <1291743428-19642-3-git-send-email-wey-yi.w.guy@intel.com>
On Tue, Dec 07, 2010 at 09:37:07AM -0800, Wey-Yi Guy wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> The current EEPROM reading code has some layout
> assumptions that now turned out to be false with
> some newer versions of the EEPROM. Luckily, we
> can avoid all such assumptions by using data in
> the EEPROM itself, so implement using that.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Is rewriting the EEPROM code really necessary for 2.6.37? This seems
like a lot of code to potentially get wrong...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-12-07 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 17:37 [PATCH 0/3] iwlwifi fix for 2.6.37 Wey-Yi Guy
2010-12-07 17:37 ` [PATCH 1/3] iwlagn: rename enhanced txpower fields Wey-Yi Guy
2010-12-07 17:37 ` [PATCH 2/3] iwlagn: implement layout-agnostic EEPROM reading Wey-Yi Guy
2010-12-07 19:28 ` John W. Linville [this message]
2010-12-07 19:45 ` Guy, Wey-Yi
2010-12-08 20:19 ` John W. Linville
2010-12-08 23:33 ` Guy, Wey-Yi
2010-12-09 1:48 ` John W. Linville
2010-12-09 6:30 ` Guy, Wey-Yi
2010-12-07 17:37 ` [PATCH 3/3] iwlwifi: minor txp entries fix Wey-Yi Guy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207192806.GF2700@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=johannes.berg@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).