From: "John W. Linville" <linville@tuxdriver.com>
To: Javier Cardona <javier@cozybit.com>
Cc: Steve Derosier <steve@cozybit.com>,
devel@lists.open80211s.org, linux-wireless@vger.kernel.org,
Jiri Slaby <jirislaby@gmail.com>,
Nick Kossifidis <mickflemm@gmail.com>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>,
Bob Copeland <me@bobcopeland.com>
Subject: Re: [PATCH 1/3] ath5k: Fix beaconing in mesh mode
Date: Tue, 7 Dec 2010 15:58:12 -0500 [thread overview]
Message-ID: <20101207205812.GK2700@tuxdriver.com> (raw)
In-Reply-To: <1291169919-3867-2-git-send-email-javier@cozybit.com>
Missing Signed-off-by...
On Tue, Nov 30, 2010 at 06:18:37PM -0800, Javier Cardona wrote:
> This patch fixes the oops below when attempting to bring up a mesh
> interface on ath5k hardware.
>
> [ 128.933099] kernel BUG at drivers/net/wireless/ath/ath5k/base.c:197!
> [ 128.933099] invalid opcode: 0000 [#1]
> (...)
> [ 128.933099] Call Trace:
> [ 128.933099] [<c83b77fa>] ? ath5k_beacon_update+0x57/0x1f8 [ath5k]
> [ 128.933099] [<c02d9a40>] ? __sysfs_add_one+0x28/0x76
> [ 128.933099] [<c83b830e>] ? ath5k_bss_info_changed+0x13f/0x173
> [ath5k]
> [ 128.933099] [<c82ff629>] ? ieee80211_config_beacon+0xc0/0x17e
> [mac80211]
> [ 128.933099] [<c82f073e>] ?
> ieee80211_bss_info_change_notify+0x182/0x18b [mac80211]
> [ 128.933099] [<c83b81cf>] ? ath5k_bss_info_changed+0x0/0x173 [ath5k]
> [ 128.933099] [<c82ff6d6>] ? ieee80211_config_beacon+0x16d/0x17e
> [mac80211]
> [ 128.933099] [<c82ff753>] ? ieee80211_add_beacon+0x34/0x39 [mac80211]
> [ 128.933099] [<c830a4ed>] ? ieee80211s_init+0xf8/0x10f [mac80211]
> [ 128.933099] [<c830a5df>] ? ieee80211_mesh_init_sdata+0xdb/0x154 [mac80211]
> ---
> drivers/net/wireless/ath/ath5k/base.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
> index a8d380a..73c7118 100644
> --- a/drivers/net/wireless/ath/ath5k/base.c
> +++ b/drivers/net/wireless/ath/ath5k/base.c
> @@ -1921,8 +1921,9 @@ ath5k_beacon_send(struct ath5k_softc *sc)
> /* NB: hw still stops DMA, so proceed */
> }
>
> - /* refresh the beacon for AP mode */
> - if (sc->opmode == NL80211_IFTYPE_AP)
> + /* refresh the beacon for AP or MESH mode */
> + if (sc->opmode == NL80211_IFTYPE_AP ||
> + sc->opmode == NL80211_IFTYPE_MESH_POINT)
> ath5k_beacon_update(sc->hw, vif);
>
> ath5k_hw_set_txdp(ah, sc->bhalq, bf->daddr);
> @@ -2826,7 +2827,8 @@ static int ath5k_add_interface(struct ieee80211_hw *hw,
>
> /* Assign the vap/adhoc to a beacon xmit slot. */
> if ((avf->opmode == NL80211_IFTYPE_AP) ||
> - (avf->opmode == NL80211_IFTYPE_ADHOC)) {
> + (avf->opmode == NL80211_IFTYPE_ADHOC) ||
> + (avf->opmode == NL80211_IFTYPE_MESH_POINT)) {
> int slot;
>
> WARN_ON(list_empty(&sc->bcbuf));
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-12-07 21:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 2:18 ath5k: Fixes for mesh operation Javier Cardona
2010-12-01 2:18 ` [PATCH 1/3] ath5k: Fix beaconing in mesh mode Javier Cardona
2010-12-01 13:16 ` Bob Copeland
2010-12-01 18:23 ` Javier Cardona
2010-12-02 1:16 ` Bruno Randolf
2010-12-07 20:58 ` John W. Linville [this message]
2010-12-07 21:35 ` Javier Cardona
2010-12-01 2:18 ` [PATCH 2/3] ath5k: Prevent mesh interfaces from being counted as ad-hoc Javier Cardona
2010-12-07 20:58 ` John W. Linville
2010-12-07 21:36 ` Javier Cardona
2010-12-01 2:18 ` [PATCH 3/3] ath5k: Put the right tsf value in mesh beacons Javier Cardona
2010-12-07 20:57 ` John W. Linville
2010-12-07 21:37 ` Javier Cardona
2010-12-07 19:12 ` ath5k: Fixes for mesh operation Javier Cardona
2010-12-07 20:57 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207205812.GK2700@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=devel@lists.open80211s.org \
--cc=javier@cozybit.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=steve@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).