linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ath: Missed to clear key4 of micentry
@ 2010-12-08 14:31 Rajkumar Manoharan
  2010-12-08 14:33 ` John W. Linville
  0 siblings, 1 reply; 2+ messages in thread
From: Rajkumar Manoharan @ 2010-12-08 14:31 UTC (permalink / raw)
  To: linville; +Cc: linux-wireless, Rajkumar Manoharan, stable

key4 of micentry is used, if ATH_CRYPT_CAP_MIC_COMBINED is set.
But is not cleared on key cache reset.

Cc: stable@kernel.org
Signed-off-by: Rajkumar Manoharan <rmanoharan@atheros.com>
---
 drivers/net/wireless/ath/key.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/key.c b/drivers/net/wireless/ath/key.c
index 29a2961..5d465e5 100644
--- a/drivers/net/wireless/ath/key.c
+++ b/drivers/net/wireless/ath/key.c
@@ -58,6 +58,8 @@ bool ath_hw_keyreset(struct ath_common *common, u16 entry)
 		REG_WRITE(ah, AR_KEYTABLE_KEY1(micentry), 0);
 		REG_WRITE(ah, AR_KEYTABLE_KEY2(micentry), 0);
 		REG_WRITE(ah, AR_KEYTABLE_KEY3(micentry), 0);
+		if (common->crypt_caps & ATH_CRYPT_CAP_MIC_COMBINED)
+			REG_WRITE(ah, AR_KEYTABLE_KEY4(micentry), 0);
 
 	}
 
-- 
1.7.3.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ath: Missed to clear key4 of micentry
  2010-12-08 14:31 [PATCH] ath: Missed to clear key4 of micentry Rajkumar Manoharan
@ 2010-12-08 14:33 ` John W. Linville
  0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2010-12-08 14:33 UTC (permalink / raw)
  To: Rajkumar Manoharan; +Cc: linux-wireless, stable

On Wed, Dec 08, 2010 at 08:01:05PM +0530, Rajkumar Manoharan wrote:
> key4 of micentry is used, if ATH_CRYPT_CAP_MIC_COMBINED is set.
> But is not cleared on key cache reset.
> 
> Cc: stable@kernel.org
> Signed-off-by: Rajkumar Manoharan <rmanoharan@atheros.com>

Which results in...?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-12-08 14:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-08 14:31 [PATCH] ath: Missed to clear key4 of micentry Rajkumar Manoharan
2010-12-08 14:33 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).