Re: [PATCH 2/3] iwlagn: implement layout-agnostic EEPROM reading

["John W. Linville" <linville@tuxdriver.com>]

On Tue, Dec 07, 2010 at 11:45:18AM -0800, Guy, Wey-Yi wrote:
> Hi John,
> 
> On Tue, 2010-12-07 at 11:28 -0800, John W. Linville wrote:
> > On Tue, Dec 07, 2010 at 09:37:07AM -0800, Wey-Yi Guy wrote:
> > > From: Johannes Berg <johannes.berg@intel.com>
> > > 
> > > The current EEPROM reading code has some layout
> > > assumptions that now turned out to be false with
> > > some newer versions of the EEPROM. Luckily, we
> > > can avoid all such assumptions by using data in
> > > the EEPROM itself, so implement using that.
> > > 
> > > Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> > > Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
> > 
> > Is rewriting the EEPROM code really necessary for 2.6.37?  This seems
> > like a lot of code to potentially get wrong...
> > 
> 
> I agree it is a lot of changes. It is necessary for 6005 and 6030
> devices. I understand the Hardware is not out yet; but both devices is
> already supported by .37; without this changes, the regulatory will have
> issues.
> 
> Yes, you are correct, this changes will also impact the older devices
> (6000, 6050, 1000). 
> 
> So it is really judgment call, we plan to release both 6005 and 6030
> uCode in the next few weeks and hardware should be on the market early
> next year. If by the time when hardware become available, distro already
> move to .38, then I am ok with it. What you think?

What about a patch to disable those devices in 2.6.37, and leave the
existing EEPROM code alone for that release?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.