From: Christian Lamparter <chunkeey@googlemail.com>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com,
lrodriguez@atheros.com, vasanth@atheros.com
Subject: Re: [PATCH v2 5/7] ath9k_hw: fix PA predistortion training power selection
Date: Mon, 13 Dec 2010 11:52:49 +0100 [thread overview]
Message-ID: <201012131152.50095.chunkeey@googlemail.com> (raw)
In-Reply-To: <1292226056-56008-5-git-send-email-nbd@openwrt.org>
On Monday 13 December 2010 08:40:54 Felix Fietkau wrote:
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_paprd.c b/drivers/net/wireless/ath/ath9k/ar9003_paprd.c
> index cdca4c3..69f7792 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_paprd.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_paprd.c
> @@ -30,9 +30,69 @@ void ar9003_paprd_enable(struct ath_hw *ah, bool val)
> +
> +static int get_streams(int mask)
> +{
> + return !!(mask & BIT(0)) + !!(mask & BIT(1)) + !!(mask & BIT(2));
> +}
> +
I think there's a generic library function for that:
hweight[8|16|32].
Also, some CPUs have a special "population count" instruction
and hweight* takes full advantage of that too.
Regards,
Chr
next prev parent reply other threads:[~2010-12-13 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 7:40 [PATCH v2 1/7] ath9k_hw: initialize ah->slottime Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 2/7] ath9k_hw: fix the slot time setting for long distance links Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 3/7] ath9k: fix PA predistortion thermal measurement handling Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 4/7] ath9k_hw: fix the PA predistortion rate mask Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 5/7] ath9k_hw: fix PA predistortion training power selection Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 6/7] ath9k_hw: update AR9003 initvals for improved radar detection Felix Fietkau
2010-12-13 7:40 ` [PATCH v2 7/7] ath9k_hw: update AR9003 initvals to improve carrier leak calibration/correction Felix Fietkau
2010-12-13 10:52 ` Christian Lamparter [this message]
2010-12-13 10:20 ` [PATCH v2 5/7] ath9k_hw: fix PA predistortion training power selection Johannes Berg
2010-12-13 11:28 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012131152.50095.chunkeey@googlemail.com \
--to=chunkeey@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=nbd@openwrt.org \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).