From: Bruno Randolf <br1@einfach.org>
To: Daniel Halperin <dhalperi@cs.washington.edu>
Cc: johannes@sipsolutions.net, linville@tuxdriver.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] nl80211: Export available antennas
Date: Wed, 15 Dec 2010 18:53:10 +0900 [thread overview]
Message-ID: <201012151853.10256.br1@einfach.org> (raw)
In-Reply-To: <AANLkTi=6o=tK1fRhOtchT9UPy+EWCcqzhebVYv+8XJP3@mail.gmail.com>
On Tue December 14 2010 12:11:52 Daniel Halperin wrote:
> Several of the Intel ones, I believe. For instance 4965 can RX with 3
> antennas but can maybe only TX with A and B? Intel also has a 1x2
> (5100 maybe?) chipset.
A lot of maybees ;) Can anyone else comment? Do we need available antennas
separately for RX and TX?
bruno
> On Mon, Dec 13, 2010 at 6:31 PM, Bruno Randolf <br1@einfach.org> wrote:
> > On Tue December 14 2010 11:23:09 Daniel Halperin wrote:
> >> > diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h
> >> > index b8fa25d..63b603c 100644
> >> > --- a/include/linux/nl80211.h
> >> > +++ b/include/linux/nl80211.h
> >> > @@ -841,6 +841,9 @@ enum nl80211_commands {
> >> > * the hardware should not be configured to receive on this
> >> > antenna. * For a more detailed descripton see
> >> > @NL80211_ATTR_WIPHY_ANTENNA_TX. *
> >> > + * @NL80211_ATTR_WIPHY_ANTENNA_AVAIL: Bitmap of antennas which are
> >> > available for + * configuration via the above parameters.
> >> > + *
> >>
> >> Not clear exactly what the point of this is -- there's no commit
> >> message -- but should not this API distinguish between TX and RX?
> >> E.g., several chipsets can only TX from a subset of RX antennas.
> >
> > This is just the nl80211 part of a patch that got merged earlier, the
> > description of which has more info:
> >
> > https://patchwork.kernel.org/patch/389682/
> >
> > If it's necessary to distinguish between RX and TX it has to be done
> > there too. Can you give us examples of these chipsets which you
> > mentioned?
> >
> > bruno
next prev parent reply other threads:[~2010-12-15 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 2:20 [PATCH 1/2] nl80211: Export available antennas Bruno Randolf
2010-12-14 2:20 ` [PATCH 2/2] ath5k: Set available antenna information for cfg80211 Bruno Randolf
2010-12-14 2:23 ` [PATCH 1/2] nl80211: Export available antennas Daniel Halperin
2010-12-14 2:31 ` Bruno Randolf
2010-12-14 3:11 ` Daniel Halperin
2010-12-15 9:53 ` Bruno Randolf [this message]
2010-12-15 18:36 ` Daniel Halperin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201012151853.10256.br1@einfach.org \
--to=br1@einfach.org \
--cc=dhalperi@cs.washington.edu \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).