From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
Elvis Dowson <elvis.dowson@mac.com>, "Kahn, Gery" <geryk@ti.com>,
Oz Krakowski <ozk@ti.com>,
Linux Wireless Mailing List <linux-wireless@vger.kernel.org>
Subject: Re: Backporting wl1271 driver to kernel-2.6.32 using compat-wireless
Date: Wed, 22 Dec 2010 12:32:27 -0500 [thread overview]
Message-ID: <20101222173227.GB10046@tuxdriver.com> (raw)
In-Reply-To: <AANLkTi=dz1eS9fdyQiZ_P41sL77HQJzCuMVKgW36JcTx@mail.gmail.com>
On Wed, Dec 22, 2010 at 12:22:21PM -0500, Luis R. Rodriguez wrote:
> On Wed, Dec 22, 2010 at 12:21 PM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> > On Wed, Dec 22, 2010 at 11:47 AM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> >> On 12/22/2010 05:13 PM, Luis R. Rodriguez wrote:
> >>> On Wed, Dec 22, 2010 at 11:09 AM, Elvis Dowson <elvis.dowson@mac.com> wrote:
> >>>> netdev_alloc_skb_ip_align
> >>>
> >>> I notice you have an android kernel, is that kernel a vanilla kernel
> >>> or did it get netdev_alloc_skb_ip_align() cherry picked into it?
> >>>
> >>> Luis
> >>
> >> netdev_alloc_skb_ip_align is not defined in the 2.6.32.27 vanilla
> >> kernel. Someone else (google or ti) must have backported it to this
> >> kernel and added it to your kernel.
> >>
> >> I do not want to add some special handling into compat-wireless just for
> >> some android kernel. Just remove netdev_alloc_skb_ip_align() and
> >> NETDEV_POST_INIT from include/linux/compat-2.6.33.h and the compile
> >> problems you posted should be fixed.
> >
> > Well we did something to accommodate RHEL, I wouldn't mind supporting
> > some fudge for Android so long as someone is willing to submit the
> > patch and identify the kernel properly. Android is popular enough and
> > I rather reduce the time it takes to use it there than to create an
> > extra hurdle.
>
> Now that I think about it I don't think John ever respinned his
> patches for compat-wireless for RHEL.
No, I didn't. Johannes wanted some sort of API level indicator instead
of checking for RHEL kernels, but I have no idea how to implement that.
FWIW, I'd rather you just take the patches I submitted and any
similar patches for other Enterprise-y distros (including Android).
But if someone else can demonstrate a workable, better alternative
then I will try to comply.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-12-22 17:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1CA1EE34-CB3D-404D-ADEE-612C8783BFCF@mac.com>
[not found] ` <AANLkTin8RZwVrWAdNn_Q+_bX8BAHgKreyHiVjznZtMxU@mail.gmail.com>
[not found] ` <1A56906E-D786-45E6-9C77-C9D600B508B0@mac.com>
[not found] ` <AANLkTikhLKuw56BhDkBUMU-nf8ZYF1v5Berj-+qupAtO@mail.gmail.com>
[not found] ` <E90F18E9-6332-4A7C-97DA-01169E5BB5E1@mac.com>
[not found] ` <AANLkTik6m0rabY3ZCseoch7fwxhMksMD83A-ygtN4cVu@mail.gmail.com>
2010-12-22 11:30 ` Backporting wl1271 driver to kernel-2.6.32 using compat-wireless Elvis Dowson
2010-12-22 15:39 ` Kahn, Gery
[not found] ` <AANLkTi=owvDyO3qfahUwRv4MxJrvMK9hjh5NOwRHQuO+@mail.gmail.com>
2010-12-22 16:09 ` Elvis Dowson
2010-12-22 16:13 ` Luis R. Rodriguez
2010-12-22 16:47 ` Hauke Mehrtens
2010-12-22 17:21 ` Luis R. Rodriguez
2010-12-22 17:22 ` Luis R. Rodriguez
2010-12-22 17:32 ` John W. Linville [this message]
2010-12-22 17:29 ` Elvis Dowson
2010-12-22 17:39 ` Luis R. Rodriguez
2010-12-22 18:13 ` Hauke Mehrtens
2010-12-22 19:34 ` Elvis Dowson
2010-12-22 20:03 ` Elvis Dowson
2010-12-22 20:12 ` Hauke Mehrtens
2010-12-22 20:34 ` Elvis Dowson
2010-12-22 21:00 ` Hauke Mehrtens
2010-12-22 21:07 ` Elvis Dowson
2010-12-23 5:52 ` Ohad Ben-Cohen
2010-12-23 21:12 ` Elvis Dowson
2010-12-25 8:05 ` Ohad Ben-Cohen
2010-12-23 9:44 ` Elvis Dowson
2010-12-23 14:57 ` Elvis Dowson
2010-12-23 15:56 ` Elvis Dowson
2010-12-23 15:33 ` Elvis Dowson
2010-12-24 5:17 ` Elvis Dowson
2010-12-25 8:02 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222173227.GB10046@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=elvis.dowson@mac.com \
--cc=geryk@ti.com \
--cc=hauke@hauke-m.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=ozk@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).