From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: linux-wireless@vger.kernel.org, stable@kernel.org,
Paul Stewart <pstew@google.com>,
Amod Bodas <amod.bodas@atheros.com>
Subject: Re: [PATCH] ath9k: fix aphy / wiphy idle mismatch
Date: Wed, 22 Dec 2010 13:28:51 -0500 [thread overview]
Message-ID: <20101222182851.GC10046@tuxdriver.com> (raw)
In-Reply-To: <1292862599-26335-1-git-send-email-lrodriguez@atheros.com>
On Mon, Dec 20, 2010 at 11:29:59AM -0500, Luis R. Rodriguez wrote:
> ath9k supports its own set of virtual wiphys, and it uses
> the mac80211 idle notifications to know when a device needs
> to be idle or not. We recently changed ath9k to force idle
> on driver stop() and on resume but forgot to take into account
> ath9k's own virtual wiphy idle states. These are used internally
> by ath9k to check if the device's radio should be powered down
> on each idle call. Without this change its possible that the
> device could have been forced off but the virtual wiphy idle
> was left on.
>
> Cc: stable@kernel.org
> Cc: Paul Stewart <pstew@google.com>
> Cc: Amod Bodas <amod.bodas@atheros.com>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
> ---
>
> I'm not yet sure if this actually fixes an issue but it
> certainly is a proper ammendment to the other idle fix
> submitted for stable for suspend/resume.
Can you refresh me on which patch that is?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2010-12-22 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 16:29 [PATCH] ath9k: fix aphy / wiphy idle mismatch Luis R. Rodriguez
2010-12-22 18:28 ` John W. Linville [this message]
2010-12-22 18:31 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101222182851.GC10046@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=amod.bodas@atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=pstew@google.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).