From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:48665 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751882Ab0LVSaK (ORCPT ); Wed, 22 Dec 2010 13:30:10 -0500 Date: Wed, 22 Dec 2010 13:28:51 -0500 From: "John W. Linville" To: "Luis R. Rodriguez" Cc: linux-wireless@vger.kernel.org, stable@kernel.org, Paul Stewart , Amod Bodas Subject: Re: [PATCH] ath9k: fix aphy / wiphy idle mismatch Message-ID: <20101222182851.GC10046@tuxdriver.com> References: <1292862599-26335-1-git-send-email-lrodriguez@atheros.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1292862599-26335-1-git-send-email-lrodriguez@atheros.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Dec 20, 2010 at 11:29:59AM -0500, Luis R. Rodriguez wrote: > ath9k supports its own set of virtual wiphys, and it uses > the mac80211 idle notifications to know when a device needs > to be idle or not. We recently changed ath9k to force idle > on driver stop() and on resume but forgot to take into account > ath9k's own virtual wiphy idle states. These are used internally > by ath9k to check if the device's radio should be powered down > on each idle call. Without this change its possible that the > device could have been forced off but the virtual wiphy idle > was left on. > > Cc: stable@kernel.org > Cc: Paul Stewart > Cc: Amod Bodas > Signed-off-by: Luis R. Rodriguez > --- > > I'm not yet sure if this actually fixes an issue but it > certainly is a proper ammendment to the other idle fix > submitted for stable for suspend/resume. Can you refresh me on which patch that is? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.