From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.atheros.com ([12.19.149.2]:48191 "EHLO mail.atheros.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752077Ab0LWCEr (ORCPT ); Wed, 22 Dec 2010 21:04:47 -0500 Received: from mail.atheros.com ([10.10.20.108]) by sidewinder.atheros.com for ; Wed, 22 Dec 2010 18:04:31 -0800 Date: Thu, 23 Dec 2010 07:34:39 +0530 From: Senthil Balasubramanian To: Luis Rodriguez CC: "Luis R. Rodriguez" , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , Stable Kernel Subject: Re: [PATCH v3 1/2] ath9k_hw: Fix incorrect macversion and macrev checks Message-ID: <20101223020439.GC4215@senthil-lnx.users.atheros.com> References: <1293032660-3627-1-git-send-email-senthilkumar@atheros.com> <20101223015542.GA4215@senthil-lnx.users.atheros.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: <20101223015542.GA4215@senthil-lnx.users.atheros.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Dec 23, 2010 at 07:25:42AM +0530, Senthilkumar Balasubramanian wrote: > On Wed, Dec 22, 2010 at 09:22:06PM +0530, Luis R. Rodriguez wrote: > > On Wed, Dec 22, 2010 at 10:44 AM, Senthil Balasubramanian > > wrote: > > > There are few places where we are checking for macversion and revsions > > > before RTC is powered ON. However we are reading the macversion and > > > revisions only after RTC is powered ON and so both macversion and > > > revisions are actully zero and this leads to incorrect srev checks > > > > > > Incorrect srev checks can cause registers to be configured wrongly and can > > > cause unexpected behavior. Fixing this seems to address the ASPM issue that > > > we have observed. The laptop becomes very slow and hangs mostly with ASPM L1 > > > enabled without this fix. > > > > On what chipset? Or did we see this on one chipset and suspect it can > > affect others? > We have noticed on Merlin and it is obviously incorrect for other chipsets This should be read as "we have noticed this issue with ar9380/ar9382" > also :-(. Please feel free to rephrase/rework on this patch if you think > something is still lacking/missing... > > > > Luis