[PATCH] b43: N-PHY: enable support for PHYs rev 3 and higher

[PATCH] b43: N-PHY: enable support for PHYs rev 3 and higher

[Rafał Miłecki]

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
---
John: can we still make it for 2.6.38 merge? It was tested with 14e4:432b,
support seems to be on the same level as for PHYs 1 and 2.
---
 drivers/net/wireless/b43/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c
index 5fb0bc6..22bc9f1 100644
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -4056,7 +4056,7 @@ static int b43_phy_versioning(struct b43_wldev *dev)
 		break;
 #ifdef CONFIG_B43_PHY_N
 	case B43_PHYTYPE_N:
-		if (phy_rev > 2)
+		if (phy_rev > 9)
 			unsupported = 1;
 		break;
 #endif
-- 
1.6.3.3

Re: [PATCH] b43: N-PHY: enable support for PHYs rev 3 and higher

[Rafał Miłecki]

W dniu 21 grudnia 2010 21:29 użytkownik Rafał Miłecki
<zajec5@gmail.com> napisał:
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> John: can we still make it for 2.6.38 merge? It was tested with 14e4:432b,
> support seems to be on the same level as for PHYs 1 and 2.

John, I dont see patches for rev3+ in wireless-testing. Any problems with them?

It means:
[PATCH 1/4] b43: use correct firmware for newer cores
[PATCH 2/4 v2] b43: N-PHY: implement radio 2056 init steps
[PATCH 3/4] b43: N-PHY: add init tables for 2056 radio
[PATCH 4/4] b43: N-PHY: avoid PHY hangs for rev 3 and 4

[PATCH 1/2] b43: N-PHY: use correct channel tables for rev4+
[PATCH 2/2 v2] b43: N-PHY: update 2056 radio on channel switch on rev3+
and this one.

-- 
Rafał

Re: [PATCH] b43: N-PHY: enable support for PHYs rev 3 and higher

[Larry Finger]

On 01/04/2011 09:50 AM, Rafał Miłecki wrote:
> W dniu 21 grudnia 2010 21:29 użytkownik Rafał Miłecki
> <zajec5@gmail.com> napisał:
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>> ---
>> John: can we still make it for 2.6.38 merge? It was tested with 14e4:432b,
>> support seems to be on the same level as for PHYs 1 and 2.
> 
> John, I dont see patches for rev3+ in wireless-testing. Any problems with them?
> 
> It means:
> [PATCH 1/4] b43: use correct firmware for newer cores
> [PATCH 2/4 v2] b43: N-PHY: implement radio 2056 init steps
> [PATCH 3/4] b43: N-PHY: add init tables for 2056 radio
> [PATCH 4/4] b43: N-PHY: avoid PHY hangs for rev 3 and 4
> 
> [PATCH 1/2] b43: N-PHY: use correct channel tables for rev4+
> [PATCH 2/2 v2] b43: N-PHY: update 2056 radio on channel switch on rev3+
> and this one.

John,

I have been testing these patches with a 14e4:432b device for at least two
weeks. With them, the driver still does not handle WPA/WPA2 encryption and falls
over with OFDM rates, but it is rock solid with WEP encryption and at 11 Mb/s.
Rafał and I have some ideas why the limitations, but the holidays have
interfered with debugging.

Larry

Re: [PATCH] b43: N-PHY: enable support for PHYs rev 3 and higher

[John W. Linville]

On Tue, Jan 04, 2011 at 10:08:36AM -0600, Larry Finger wrote:
> On 01/04/2011 09:50 AM, Rafał Miłecki wrote:
> > W dniu 21 grudnia 2010 21:29 użytkownik Rafał Miłecki
> > <zajec5@gmail.com> napisał:
> >> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> >> ---
> >> John: can we still make it for 2.6.38 merge? It was tested with 14e4:432b,
> >> support seems to be on the same level as for PHYs 1 and 2.
> > 
> > John, I dont see patches for rev3+ in wireless-testing. Any problems with them?
> > 
> > It means:
> > [PATCH 1/4] b43: use correct firmware for newer cores
> > [PATCH 2/4 v2] b43: N-PHY: implement radio 2056 init steps
> > [PATCH 3/4] b43: N-PHY: add init tables for 2056 radio
> > [PATCH 4/4] b43: N-PHY: avoid PHY hangs for rev 3 and 4
> > 
> > [PATCH 1/2] b43: N-PHY: use correct channel tables for rev4+
> > [PATCH 2/2 v2] b43: N-PHY: update 2056 radio on channel switch on rev3+
> > and this one.
> 
> John,
> 
> I have been testing these patches with a 14e4:432b device for at least two
> weeks. With them, the driver still does not handle WPA/WPA2 encryption and falls
> over with OFDM rates, but it is rock solid with WEP encryption and at 11 Mb/s.
> Rafał and I have some ideas why the limitations, but the holidays have
> interfered with debugging.
> 
> Larry

And with merging...

I hope to get caught-up soon.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

Re: [PATCH] b43: N-PHY: enable support for PHYs rev 3 and higher

[Larry Finger]

On 01/04/2011 12:11 PM, John W. Linville wrote:
> On Tue, Jan 04, 2011 at 10:08:36AM -0600, Larry Finger wrote:
>> On 01/04/2011 09:50 AM, Rafał Miłecki wrote:
>>> W dniu 21 grudnia 2010 21:29 użytkownik Rafał Miłecki
>>> <zajec5@gmail.com> napisał:
>>>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>>>> ---
>>>> John: can we still make it for 2.6.38 merge? It was tested with 14e4:432b,
>>>> support seems to be on the same level as for PHYs 1 and 2.
>>>
>>> John, I dont see patches for rev3+ in wireless-testing. Any problems with them?
>>>
>>> It means:
>>> [PATCH 1/4] b43: use correct firmware for newer cores
>>> [PATCH 2/4 v2] b43: N-PHY: implement radio 2056 init steps
>>> [PATCH 3/4] b43: N-PHY: add init tables for 2056 radio
>>> [PATCH 4/4] b43: N-PHY: avoid PHY hangs for rev 3 and 4
>>>
>>> [PATCH 1/2] b43: N-PHY: use correct channel tables for rev4+
>>> [PATCH 2/2 v2] b43: N-PHY: update 2056 radio on channel switch on rev3+
>>> and this one.
>>
>> John,
>>
>> I have been testing these patches with a 14e4:432b device for at least two
>> weeks. With them, the driver still does not handle WPA/WPA2 encryption and falls
>> over with OFDM rates, but it is rock solid with WEP encryption and at 11 Mb/s.
>> Rafał and I have some ideas why the limitations, but the holidays have
>> interfered with debugging.
>>
>> Larry
> 
> And with merging...
> 
> I hope to get caught-up soon.

I hope there are some rtlwifi/rtl8192ce updates there as well. I'll wait for
some new merges before I bug you about the specific patches.

Larry