From: "Henry Ptasinski" <henryp@broadcom.com>
To: "Greg KH" <gregkh@suse.de>
Cc: "Arend Van Spriel" <arend@broadcom.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Henry Ptasinski" <henryp@broadcom.com>
Subject: Re: [PATCH] staging: brcm80211: fix suspend/resume issue in brcmsmac
Date: Wed, 12 Jan 2011 11:44:39 -0800 [thread overview]
Message-ID: <20110112194438.GJ2466@broadcom.com> (raw)
In-Reply-To: <20110112180829.GB10224@suse.de>
On Wed, Jan 12, 2011 at 10:08:29AM -0800, Greg KH wrote:
> On Wed, Jan 12, 2011 at 06:59:27PM +0100, Arend van Spriel wrote:
> > PCI PM suspend callback took down the interface and resume brought
> > it back up. In the mac80211 context this is done in subsequent calls.
> > Rework implementation so that suspend only stores config, and sets
> > PCI power state. The resume return to full power state (D0), restores
> > the config, and brings hardware back up. Full bringup is done by
> > subsequent mac80211 calls.
>
> Ah, does this solve the suspend/resume bug that a number of people have
> reported for the driver since the .36 release? If so, should it go into
> the kernel now and be backported to older releases?
Yes, this should solve the suspend/resume bug that people have reported.
(It doesn't solve the rfkill issues; Arend is working on a separate fix for
that.)
It should get backported, but it would be nice to get some confirmation from
people that it fixes the issues they're seeing first.
- Henry
next prev parent reply other threads:[~2011-01-12 19:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 17:59 [PATCH] staging: brcm80211: fix suspend/resume issue in brcmsmac Arend van Spriel
2011-01-12 18:08 ` Greg KH
2011-01-12 19:44 ` Henry Ptasinski [this message]
2011-01-12 22:41 ` Greg KH
2011-01-20 20:17 ` Greg KH
2011-01-21 14:37 ` Arend Van Spriel
2011-01-21 15:12 ` Greg KH
2011-01-21 21:36 ` Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112194438.GJ2466@broadcom.com \
--to=henryp@broadcom.com \
--cc=arend@broadcom.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).