From: Helmut Schaa <helmut.schaa@googlemail.com>
To: Ivo Van Doorn <ivdoorn@gmail.com>
Cc: Ingo Brunberg <ingo_brunberg@web.de>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: BUG in rt2x00lib_txdone() with 2.6.37-rc8
Date: Sun, 16 Jan 2011 02:59:14 +0100 [thread overview]
Message-ID: <201101160259.14404.helmut.schaa@googlemail.com> (raw)
In-Reply-To: <AANLkTimMVdsGONSD9OmnX2eJk51H5Pzj4K8irHa=E-qx@mail.gmail.com>
Am Samstag, 15. Januar 2011 schrieb Ivo Van Doorn:
> Hi,
>
> > Just a shot in the dark but since the stack trace shows the newly added
> > watchdog this might be the result of a race between a regular txdone work
> > (mac80211 workqueue) vs the watchdog work (global workqueue).
> >
> > I guess the following situation could happen:
> > A regular tx done work calls rt2x00lib_txdone which first sets entry->skb to
> > NULL, calls the driver specific clear_entry and afterwards increases
> > Q_INDEX_DONE. If the watchdog work calls rt2x00lib_txdone on a different CPU
> > inbetween the skb might be NULL and cause the above oops.
>
> This could be, would be interesting to know if compat-wireless also shows
> this problem. Because the queue refactoring code which should have solved
> these race conditions was added after 2.6.37.
I also guess that this issue would be fixed in compat-wireless due to the queue
refactoring. But I guess that is way too big for a stable kernel :(
Helmut
next prev parent reply other threads:[~2011-01-16 2:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m31v4hkmkf.fsf@ingo.homenetwork>
2011-01-13 13:23 ` BUG in rt2x00lib_txdone() with 2.6.37-rc8 Helmut Schaa
2011-01-15 13:34 ` Ivo Van Doorn
2011-01-16 1:59 ` Helmut Schaa [this message]
2011-01-16 2:58 ` Ingo Brunberg
2011-01-17 20:36 ` Ivo Van Doorn
2011-01-12 22:34 Michele Ballabio
-- strict thread matches above, loose matches on Subject: below --
2010-12-31 10:23 Stephen Boyd
2011-01-01 10:28 ` Heinz Diehl
2011-01-01 21:35 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101160259.14404.helmut.schaa@googlemail.com \
--to=helmut.schaa@googlemail.com \
--cc=ingo_brunberg@web.de \
--cc=ivdoorn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).