From: Rajkumar Manoharan <rmanoharan@atheros.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Rajkumar Manoharan <Rajkumar.Manoharan@Atheros.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"stable@kernel.org" <stable@kernel.org>
Subject: Re: [PATCH 2/2] ath9k: Fix power save usage count imbalance on deinit
Date: Thu, 20 Jan 2011 13:21:30 +0530 [thread overview]
Message-ID: <20110120075130.GA3431@vmraj-lnx.users.atheros.com> (raw)
In-Reply-To: <AANLkTimSBJxY0f6G6BLcLbsDySvn6KZQu=Vdj134yZLD@mail.gmail.com>
On Thu, Jan 20, 2011 at 12:54:56AM +0530, Luis R. Rodriguez wrote:
> On Wed, Jan 19, 2011 at 7:47 AM, Rajkumar Manoharan
> <rmanoharan@atheros.com> wrote:
> > Upon unloading the driver, the ps_usecount is incremented
> > before configuring gpio registers in deinit_device.
> > But it is failed to restore the ps_usecount after that.
> > The problem is that the chip is moved to FULL SLEEP
> > by radio_disable when mac80211 is reporting as idle
> > though ps_usecount is not zero.
> >
> > This patch retores ps_usecount properly and ensures that
> > the chip is always moved to full sleep only if ps usage
> > counte is zero which helps in debugging. And also fixes
> > the following warning.
> >
> > ath: DMA failed to stop in 10 ms AR_CR=0xdeadbeef AR_DIAG_SW=0xdeadbeef
> > ath: Could not stop RX, we could be confusing the DMA engine when we
> > start RX up
> > ------------[ cut here ]------------
> > WARNING: at drivers/net/wireless/ath/ath9k/recv.c:536
> > ath_stoprecv+0xf4/0x100 [ath9k]()
> >
>
> Are you sure this hunk does not regress the suspend/resume case when
> using the new dbus API?
>
I verfied the suspend/resume case with AR9280 card. But I don't
understand how the new dbus API is related with this patch?
--
Rajkumar
next prev parent reply other threads:[~2011-01-20 7:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 15:47 [PATCH 1/2] ath9k_hw: Fix system hang when resuming from S3/S4 Rajkumar Manoharan
2011-01-19 15:47 ` [PATCH 2/2] ath9k: Fix power save usage count imbalance on deinit Rajkumar Manoharan
2011-01-19 19:24 ` Luis R. Rodriguez
2011-01-20 7:51 ` Rajkumar Manoharan [this message]
2011-01-20 23:02 ` Luis R. Rodriguez
2011-01-23 7:21 ` Rajkumar Manoharan
2011-01-25 0:03 ` Paul Stewart
2011-01-25 5:10 ` Rajkumar Manoharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110120075130.GA3431@vmraj-lnx.users.atheros.com \
--to=rmanoharan@atheros.com \
--cc=Rajkumar.Manoharan@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox