From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: use DECLARE_EVENT_CLASS
Date: Fri, 21 Jan 2011 16:24:48 -0500 [thread overview]
Message-ID: <20110121212447.GB7092@tuxdriver.com> (raw)
In-Reply-To: <1295437859.4685.4.camel@jlt3.sipsolutions.net>
On Wed, Jan 19, 2011 at 12:50:59PM +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> For events that include only the local struct as
> their parameter, we can use DECLARE_EVENT_CLASS
> and save quite some binary size across segments
> as well lines of code.
>
> text data bss dec hex filename
> 375745 19296 916 395957 60ab5 mac80211.ko.before
> 367473 17888 916 386277 5e4e5 mac80211.ko.after
> -8272 -1408 0 -9680 -25d0 delta
>
> Some more tracepoints with identical arguments
> could be combined like this but for now this is
> the one that benefits most.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Is this patch complete? It seems to break the build with undefined symbols...
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-01-21 21:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 11:50 [PATCH] mac80211: use DECLARE_EVENT_CLASS Johannes Berg
2011-01-21 21:24 ` John W. Linville [this message]
2011-01-23 10:12 ` Johannes Berg
2011-01-23 10:12 ` [PATCH v2] " Johannes Berg
2011-01-25 21:58 ` John W. Linville
2011-01-26 8:16 ` Johannes Berg
2011-01-26 8:22 ` [PATCH v3] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110121212447.GB7092@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).