From: Vasily Khoruzhick <anarsoul@gmail.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
Andrey Yurovsky <andrey@cozybit.com>,
Colin McCabe <colin@cozybit.com>
Subject: Re: [PATCH 1/3] libertas_spi: Use workqueue in hw_host_to_card
Date: Fri, 21 Jan 2011 23:24:29 +0200 [thread overview]
Message-ID: <201101212324.29978.anarsoul@gmail.com> (raw)
In-Reply-To: <201101212222.37667.marek.vasut@gmail.com>
On Friday 21 January 2011 23:22:37 Marek Vasut wrote:
> On Friday 21 January 2011 21:44:48 Vasily Khoruzhick wrote:
> > Use workqueue to perform SPI xfers, it's necessary to fix
> > nasty "BUG: scheduling while atomic", because
> > spu_write() calls spi_sync() and spi_sync() may sleep, but
> > hw_host_to_card() callback can be called from atomic context.
> > Remove kthread completely, workqueue now does its job.
> > Restore intermediate buffers which were removed in commit
> > 86c34fe89e9cad9e1ba4d1a8bbf98259035f4caf that introduced
> > mentioned bug.
>
> I have two questions:
>
> 1) Why not leave kthread there? ie. why switch to workqueue
Because it's not easy to ensure that kthread did its job in suspend handler,
and to make if_spi.c look similar to if_sdio.c.
> 2) This should be split into two patches I guess -- a) revert the change b)
> convert to workqueue -- so they can be (N)ACKed separatedly
Actually just reverting commit does not make driver work (it will fail on
rmmod), and it can impact on future bisect (if it'll be necessary). But if
it's requirement - ok.
> Cheers
next prev parent reply other threads:[~2011-01-21 21:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 20:44 [PATCH 0/3] libertas_spi fixes Vasily Khoruzhick
2011-01-21 20:44 ` [PATCH 1/3] libertas_spi: Use workqueue in hw_host_to_card Vasily Khoruzhick
2011-01-21 21:22 ` Marek Vasut
2011-01-21 21:24 ` Vasily Khoruzhick [this message]
2011-01-21 21:52 ` Dan Williams
2011-04-08 5:44 ` Colin McCabe
2011-01-21 20:44 ` [PATCH 2/3] libertas: Prepare stuff for if_spi.c pm support Vasily Khoruzhick
2011-01-21 20:44 ` [PATCH 3/3] libertas_spi: Add support for suspend/resume Vasily Khoruzhick
2011-01-21 21:25 ` Marek Vasut
2011-01-21 21:27 ` Vasily Khoruzhick
2011-01-21 21:55 ` Dan Williams
2011-01-31 19:52 ` [PATCH 0/3] libertas_spi fixes John W. Linville
2011-02-03 18:54 ` Dan Williams
2011-02-03 18:59 ` Vasily Khoruzhick
2011-02-08 12:52 ` Marek Vasut
2011-02-26 9:44 ` Vasily Khoruzhick
2011-03-15 20:31 ` Vasily Khoruzhick
2011-03-15 20:41 ` John W. Linville
2011-03-16 14:41 ` [PATCH RESEND] libertas_spi: Add support for suspend/resume Vasily Khoruzhick
2011-03-17 16:44 ` Dan Williams
2011-03-19 19:00 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101212324.29978.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=andrey@cozybit.com \
--cc=colin@cozybit.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).