linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Helmut Schaa <helmut.schaa@googlemail.com>
To: linux-wireless@vger.kernel.org
Subject: Survey data inconsistencies between drivers
Date: Mon, 24 Jan 2011 12:29:49 +0100	[thread overview]
Message-ID: <201101241229.50142.helmut.schaa@googlemail.com> (raw)

Hi,

currently there are at least three different survey types implemented in
different mac80211 drivers.

- ath9k always lists the survey data for all channels and always provides
  accumulated busy time data. This has the advantage that a simple scan
  followed   by a suvrey dump will give a nice overview of the different
  channel utilization.
- ath5k only lists the active channel but also accumlates the busy time
  statistics.
- rt2800 only lists the active channel and only returns relative busy time
  values since the last read.

>From a hw perspective all three drivers appear similar, there are some
registers that are cleared on read and contain the busy times since the
last read.

I really like the ath9k approach but implementing it in every driver
sounds like a lot of redundancy.

In order to have consistent survey data between drivers I'd propose the
following approach:

- The driver's get_survey callback only returns relative survey data for the
  currently active channel. That means reading the current busy time statistics
  from the hw and clearing the appropriate counters.
- mac80211 would keep track of accumulating the gathered survey data.
- mac80211 would read the survey data before each channel change and update
  the approriate channel's survey data just as ath9k does right now.

Any arguments against such a unification?

Thanks,
Helmut

             reply	other threads:[~2011-01-24 11:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-24 11:29 Helmut Schaa [this message]
2011-01-24 14:21 ` Survey data inconsistencies between drivers John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101241229.50142.helmut.schaa@googlemail.com \
    --to=helmut.schaa@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).