* [PATCH] brcm80211: fix error report string
@ 2011-01-24 18:45 Gustavo F. Padovan
2011-01-24 19:03 ` Gustavo F. Padovan
2011-01-24 21:17 ` Rafał Miłecki
0 siblings, 2 replies; 6+ messages in thread
From: Gustavo F. Padovan @ 2011-01-24 18:45 UTC (permalink / raw)
To: brudley, henryp, dowan, vossen, arend; +Cc: linux-wireless
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
---
drivers/staging/brcm80211/sys/wlc_mac80211.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c b/drivers/staging/brcm80211/sys/wlc_mac80211.c
index 5eb41d6..ee1bcc5 100644
--- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
+++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
@@ -6910,7 +6910,7 @@ prep_mac80211_status(struct wlc_info *wlc, d11rxhdr_t *rxh, struct sk_buff *p,
preamble = 0;
if (IS_CCK(rspec)) {
if (rxh->PhyRxStatus_0 & PRXS0_SHORTH)
- WL_ERROR("Short CCK\n");
+ WL_ERROR("%s: Short CCK\n, __func__");
rx_status->flag |= RX_FLAG_SHORTPRE;
} else if (IS_OFDM(rspec)) {
rx_status->flag |= RX_FLAG_SHORTPRE;
--
1.7.4.rc2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] brcm80211: fix error report string
2011-01-24 18:45 [PATCH] brcm80211: fix error report string Gustavo F. Padovan
@ 2011-01-24 19:03 ` Gustavo F. Padovan
2011-01-24 21:17 ` Rafał Miłecki
1 sibling, 0 replies; 6+ messages in thread
From: Gustavo F. Padovan @ 2011-01-24 19:03 UTC (permalink / raw)
To: brudley, henryp, dowan, vossen, arend; +Cc: linux-wireless
Reporting another issue here. The README file is not correct with the content
of the linux-firmware tree. Seems that the changes added in this patch
http://www.spinics.net/lists/linux-wireless/msg60937.html
never arrived to linux-firmware.
Other than that, you guys are doing a great workon putting this driver
mainline. Mine broadcom card is working fine. :)
Regards,
* Gustavo F. Padovan <padovan@profusion.mobi> [2011-01-24 16:45:23 -0200]:
> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
> ---
> drivers/staging/brcm80211/sys/wlc_mac80211.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c b/drivers/staging/brcm80211/sys/wlc_mac80211.c
> index 5eb41d6..ee1bcc5 100644
> --- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
> +++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
> @@ -6910,7 +6910,7 @@ prep_mac80211_status(struct wlc_info *wlc, d11rxhdr_t *rxh, struct sk_buff *p,
> preamble = 0;
> if (IS_CCK(rspec)) {
> if (rxh->PhyRxStatus_0 & PRXS0_SHORTH)
> - WL_ERROR("Short CCK\n");
> + WL_ERROR("%s: Short CCK\n, __func__");
> rx_status->flag |= RX_FLAG_SHORTPRE;
> } else if (IS_OFDM(rspec)) {
> rx_status->flag |= RX_FLAG_SHORTPRE;
> --
> 1.7.4.rc2
>
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] brcm80211: fix error report string
2011-01-24 18:45 [PATCH] brcm80211: fix error report string Gustavo F. Padovan
2011-01-24 19:03 ` Gustavo F. Padovan
@ 2011-01-24 21:17 ` Rafał Miłecki
2011-01-24 21:35 ` Gustavo F. Padovan
2011-01-24 21:57 ` Brett Rudley
1 sibling, 2 replies; 6+ messages in thread
From: Rafał Miłecki @ 2011-01-24 21:17 UTC (permalink / raw)
To: Gustavo F. Padovan; +Cc: brudley, henryp, dowan, vossen, arend, linux-wireless
2011/1/24 Gustavo F. Padovan <padovan@profusion.mobi>:
> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
> ---
> drivers/staging/brcm80211/sys/wlc_mac80211.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c b/drivers/staging/brcm80211/sys/wlc_mac80211.c
> index 5eb41d6..ee1bcc5 100644
> --- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
> +++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
> @@ -6910,7 +6910,7 @@ prep_mac80211_status(struct wlc_info *wlc, d11rxhdr_t *rxh, struct sk_buff *p,
> preamble = 0;
> if (IS_CCK(rspec)) {
> if (rxh->PhyRxStatus_0 & PRXS0_SHORTH)
> - WL_ERROR("Short CCK\n");
> + WL_ERROR("%s: Short CCK\n, __func__");
I have no idea how WL_ERROR works, but are you sure of that?
You wrote:
"%s: Short CCK\n, __func__"
Didn't you mean:
"%s: Short CCK\n", __func__
?
--
Rafał
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] brcm80211: fix error report string
2011-01-24 21:17 ` Rafał Miłecki
@ 2011-01-24 21:35 ` Gustavo F. Padovan
2011-01-24 21:57 ` Brett Rudley
1 sibling, 0 replies; 6+ messages in thread
From: Gustavo F. Padovan @ 2011-01-24 21:35 UTC (permalink / raw)
To: brudley, henryp, dowan, rvossen, arend; +Cc: linux-wireless
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
---
drivers/staging/brcm80211/sys/wlc_mac80211.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c b/drivers/staging/brcm80211/sys/wlc_mac80211.c
index 5eb41d6..a23dc5c 100644
--- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
+++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
@@ -6910,7 +6910,7 @@ prep_mac80211_status(struct wlc_info *wlc, d11rxhdr_t *rxh, struct sk_buff *p,
preamble = 0;
if (IS_CCK(rspec)) {
if (rxh->PhyRxStatus_0 & PRXS0_SHORTH)
- WL_ERROR("Short CCK\n");
+ WL_ERROR("%s: Short CCK\n", __func__);
rx_status->flag |= RX_FLAG_SHORTPRE;
} else if (IS_OFDM(rspec)) {
rx_status->flag |= RX_FLAG_SHORTPRE;
--
1.7.4.rc2
^ permalink raw reply related [flat|nested] 6+ messages in thread* RE: [PATCH] brcm80211: fix error report string
2011-01-24 21:17 ` Rafał Miłecki
2011-01-24 21:35 ` Gustavo F. Padovan
@ 2011-01-24 21:57 ` Brett Rudley
2011-01-25 17:00 ` Gustavo F. Padovan
1 sibling, 1 reply; 6+ messages in thread
From: Brett Rudley @ 2011-01-24 21:57 UTC (permalink / raw)
To: Rafał Miłecki, Gustavo F. Padovan
Cc: Henry Ptasinski, Dowan Kim, vossen@broadcom.com, Arend Van Spriel,
linux-wireless@vger.kernel.org
PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBSYWZhxYIgTWnFgmVja2kgW21h
aWx0bzp6YWplYzVAZ21haWwuY29tXQ0KPiBTZW50OiBNb25kYXksIEphbnVhcnkgMjQsIDIwMTEg
MToxNyBQTQ0KPiBUbzogR3VzdGF2byBGLiBQYWRvdmFuDQo+IENjOiBCcmV0dCBSdWRsZXk7IEhl
bnJ5IFB0YXNpbnNraTsgRG93YW4gS2ltOyB2b3NzZW5AYnJvYWRjb20uY29tOyBBcmVuZA0KPiBW
YW4gU3ByaWVsOyBsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6
IFtQQVRDSF0gYnJjbTgwMjExOiBmaXggZXJyb3IgcmVwb3J0IHN0cmluZw0KPiANCj4gMjAxMS8x
LzI0IEd1c3Rhdm8gRi4gUGFkb3ZhbiA8cGFkb3ZhbkBwcm9mdXNpb24ubW9iaT46DQo+ID4gU2ln
bmVkLW9mZi1ieTogR3VzdGF2byBGLiBQYWRvdmFuIDxwYWRvdmFuQHByb2Z1c2lvbi5tb2JpPg0K
PiA+IC0tLQ0KPiA+IMKgZHJpdmVycy9zdGFnaW5nL2JyY204MDIxMS9zeXMvd2xjX21hYzgwMjEx
LmMgfCDCoCDCoDIgKy0NCj4gPiDCoDEgZmlsZXMgY2hhbmdlZCwgMSBpbnNlcnRpb25zKCspLCAx
IGRlbGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy9icmNt
ODAyMTEvc3lzL3dsY19tYWM4MDIxMS5jDQo+IGIvZHJpdmVycy9zdGFnaW5nL2JyY204MDIxMS9z
eXMvd2xjX21hYzgwMjExLmMNCj4gPiBpbmRleCA1ZWI0MWQ2Li5lZTFiY2M1IDEwMDY0NA0KPiA+
IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9icmNtODAyMTEvc3lzL3dsY19tYWM4MDIxMS5jDQo+ID4g
KysrIGIvZHJpdmVycy9zdGFnaW5nL2JyY204MDIxMS9zeXMvd2xjX21hYzgwMjExLmMNCj4gPiBA
QCAtNjkxMCw3ICs2OTEwLDcgQEAgcHJlcF9tYWM4MDIxMV9zdGF0dXMoc3RydWN0IHdsY19pbmZv
ICp3bGMsDQo+IGQxMXJ4aGRyX3QgKnJ4aCwgc3RydWN0IHNrX2J1ZmYgKnAsDQo+ID4gwqAgwqAg
wqAgwqAgwqAgwqAgwqAgwqBwcmVhbWJsZSA9IDA7DQo+ID4gwqAgwqAgwqAgwqAgwqAgwqAgwqAg
wqBpZiAoSVNfQ0NLKHJzcGVjKSkgew0KPiA+IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg
IMKgIMKgaWYgKHJ4aC0+UGh5UnhTdGF0dXNfMCAmIFBSWFMwX1NIT1JUSCkNCj4gPiAtIMKgIMKg
IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIFdMX0VSUk9SKCJTaG9ydCBD
Q0tcbiIpOw0KPiA+ICsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg
wqAgV0xfRVJST1IoIiVzOiBTaG9ydCBDQ0tcbiwgX19mdW5jX18iKTsNCj4gDQo+IEkgaGF2ZSBu
byBpZGVhIGhvdyBXTF9FUlJPUiB3b3JrcywgYnV0IGFyZSB5b3Ugc3VyZSBvZiB0aGF0Pw0KPiAN
Cj4gWW91IHdyb3RlOg0KPiAiJXM6IFNob3J0IENDS1xuLCBfX2Z1bmNfXyINCj4gDQo+IERpZG4n
dCB5b3UgbWVhbjoNCj4gIiVzOiBTaG9ydCBDQ0tcbiIsIF9fZnVuY19fDQo+ID8NCj4gDQoNClJh
ZmFsJ3Mgc3VnZ2VzdGlvbiBpcyBjb3JyZWN0LCB0aGUgcGF0Y2ggd2FzIGluY29ycmVjdC4NCihH
b29kIGV5ZXMsIFJhZmFsKQ0KDQpCcmV0dA0KDQo+IC0tDQo+IFJhZmHFgg0KDQo=
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] brcm80211: fix error report string
2011-01-24 21:57 ` Brett Rudley
@ 2011-01-25 17:00 ` Gustavo F. Padovan
0 siblings, 0 replies; 6+ messages in thread
From: Gustavo F. Padovan @ 2011-01-25 17:00 UTC (permalink / raw)
To: Brett Rudley
Cc: Rafał Miłecki, Henry Ptasinski, Dowan Kim,
vossen@broadcom.com, Arend Van Spriel,
linux-wireless@vger.kernel.org
Hi Brett,
* Brett Rudley <brudley@broadcom.com> [2011-01-24 13:57:46 -0800]:
> > -----Original Message-----
> > From: Rafał Miłecki [mailto:zajec5@gmail.com]
> > Sent: Monday, January 24, 2011 1:17 PM
> > To: Gustavo F. Padovan
> > Cc: Brett Rudley; Henry Ptasinski; Dowan Kim; vossen@broadcom.com; Arend
> > Van Spriel; linux-wireless@vger.kernel.org
> > Subject: Re: [PATCH] brcm80211: fix error report string
> >
> > 2011/1/24 Gustavo F. Padovan <padovan@profusion.mobi>:
> > > Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
> > > ---
> > > drivers/staging/brcm80211/sys/wlc_mac80211.c | 2 +-
> > > 1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/drivers/staging/brcm80211/sys/wlc_mac80211.c
> > b/drivers/staging/brcm80211/sys/wlc_mac80211.c
> > > index 5eb41d6..ee1bcc5 100644
> > > --- a/drivers/staging/brcm80211/sys/wlc_mac80211.c
> > > +++ b/drivers/staging/brcm80211/sys/wlc_mac80211.c
> > > @@ -6910,7 +6910,7 @@ prep_mac80211_status(struct wlc_info *wlc,
> > d11rxhdr_t *rxh, struct sk_buff *p,
> > > preamble = 0;
> > > if (IS_CCK(rspec)) {
> > > if (rxh->PhyRxStatus_0 & PRXS0_SHORTH)
> > > - WL_ERROR("Short CCK\n");
> > > + WL_ERROR("%s: Short CCK\n, __func__");
> >
> > I have no idea how WL_ERROR works, but are you sure of that?
> >
> > You wrote:
> > "%s: Short CCK\n, __func__"
> >
> > Didn't you mean:
> > "%s: Short CCK\n", __func__
> > ?
> >
>
> Rafal's suggestion is correct, the patch was incorrect.
> (Good eyes, Rafal)
I just sent a corrected one yesterday in this thread.
--
Gustavo F. Padovan
http://profusion.mobi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-25 17:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-24 18:45 [PATCH] brcm80211: fix error report string Gustavo F. Padovan
2011-01-24 19:03 ` Gustavo F. Padovan
2011-01-24 21:17 ` Rafał Miłecki
2011-01-24 21:35 ` Gustavo F. Padovan
2011-01-24 21:57 ` Brett Rudley
2011-01-25 17:00 ` Gustavo F. Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).