From: Stanislaw Gruszka <sgruszka@redhat.com>
To: wwguy <wey-yi.w.guy@intel.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/8] iwlwifi: do not set tx power when channel is changing
Date: Fri, 28 Jan 2011 17:27:15 +0100 [thread overview]
Message-ID: <20110128162714.GD2452@redhat.com> (raw)
In-Reply-To: <1296230595.7388.4.camel@wwguy-ubuntu>
Hi
On Fri, Jan 28, 2011 at 08:03:15AM -0800, wwguy wrote:
> On Fri, 2011-01-28 at 07:47 -0800, Stanislaw Gruszka wrote:
> > Mac80211 can request for tx power and channel change in one ->config
> > call. If that happens, *_send_tx_power functions will try to setup tx
> > power for old channel, what can be not correct because we already change
> > the band. I.e error "Failed to get channel info for channel 140 [0]",
> > can be printed frequently when operating in software scanning mode.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> > ---
> > drivers/net/wireless/iwlwifi/iwl-3945.c | 2 +-
> > drivers/net/wireless/iwlwifi/iwl-4965.c | 2 +-
> > drivers/net/wireless/iwlwifi/iwl-agn-rxon.c | 5 ++---
> > drivers/net/wireless/iwlwifi/iwl-core.c | 13 ++++++++++---
> > 4 files changed, 14 insertions(+), 8 deletions(-)
> >
>
> Do you have a bugzilla bug being addressed by this patch?
No, I found this issue by myself testing, I don't know if
patch address any bugzilla report.
Stanislaw
next prev parent reply other threads:[~2011-01-28 16:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 15:47 [PATCH 1/8] iwlwifi: do not set tx power when channel is changing Stanislaw Gruszka
2011-01-28 15:47 ` [PATCH 2/8] iwl3945: set STATUS_READY before commit_rxon Stanislaw Gruszka
2011-01-28 16:04 ` wwguy
2011-01-28 15:47 ` [PATCH 3/8] iwlwifi: remove unneeded __packed Stanislaw Gruszka
2011-01-28 16:05 ` wwguy
2011-01-28 15:47 ` [PATCH 4/8] iwlwifi: introduce iwl_advanced_bt_coexist() Stanislaw Gruszka
2011-01-28 16:13 ` wwguy
2011-01-28 15:47 ` [PATCH 5/8] iwlwifi: remove unneeded disable_hw_scan check Stanislaw Gruszka
2011-01-28 16:14 ` wwguy
2011-01-28 15:47 ` [PATCH 6/8] iwl3945: do not use agn specific IWL_RATE_COUNT Stanislaw Gruszka
2011-01-28 16:20 ` wwguy
2011-01-28 16:33 ` Stanislaw Gruszka
2011-01-28 16:42 ` wwguy
2011-01-31 14:54 ` wwguy
2011-01-28 15:47 ` [PATCH 7/8] iwlagn: remove CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE Stanislaw Gruszka
2011-01-28 16:23 ` wwguy
2011-01-28 16:41 ` Stanislaw Gruszka
2011-01-28 23:20 ` wwguy
2011-01-31 9:46 ` Stanislaw Gruszka
2011-01-31 10:23 ` Rafał Miłecki
2011-01-31 11:29 ` Stanislaw Gruszka
2011-01-31 15:01 ` wwguy
2011-01-31 15:26 ` Stanislaw Gruszka
2011-01-31 14:57 ` wwguy
2011-01-28 15:47 ` [PATCH 8/8] iwlwifi: introduce iwl_bt_statistics Stanislaw Gruszka
2011-01-28 16:24 ` wwguy
2011-01-28 16:03 ` [PATCH 1/8] iwlwifi: do not set tx power when channel is changing wwguy
2011-01-28 16:27 ` Stanislaw Gruszka [this message]
2011-01-28 16:38 ` wwguy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128162714.GD2452@redhat.com \
--to=sgruszka@redhat.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).