Re: [PATCH 7/8] iwlagn: remove CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE

[Stanislaw Gruszka <sgruszka@redhat.com>]

On Fri, Jan 28, 2011 at 08:23:37AM -0800, wwguy wrote:
> > -#ifdef CONFIG_IWLWIFI_DEBUG_EXPERIMENTAL_UCODE
> >  		priv->fw_index = UCODE_EXPERIMENTAL_INDEX;
> >  		strcpy(tag, UCODE_EXPERIMENTAL_TAG);
> >  	} else if (priv->fw_index == UCODE_EXPERIMENTAL_INDEX) {
> > -#endif
> >  		priv->fw_index = priv->cfg->ucode_api_max;
> >  		sprintf(tag, "%d", priv->fw_index);
> >  	} else {
> 
> The whole reason has it in Kconfig file is to have user not remove the
> experimental uCode from /lib/firmware and not use it.

What is easiest and less time consuming:

this:

$ mv /lib/firmware/iwlwifi-5000-exp.ucode /lib/firmware/iwlwifi-5000-exp.ucode.not_use

or this:

$ make menuconfig
navigate to find option and edit it 
$ make modules
$ make modules_install

?

> Also put it in Kconfig file, so it is easy for user to see they are
> using experimental option. Agree?

Not really. I believe someone who download a tarball, unpack it and copy
files to /lib/firmware is pretty much aware what he/she is doing.

Stanislaw