linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jouni Malinen <j@w1.fi>
To: Pat Erley <pat-lkml@erley.org>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Ben Greear <greearb@candelatech.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: Why is wmm_param required for HT40- in mlme.c
Date: Mon, 31 Jan 2011 13:28:41 +0200	[thread overview]
Message-ID: <20110131112841.GA2628@jm.kir.nu> (raw)
In-Reply-To: <4D45A2B1.5050006@erley.org>

On Sun, Jan 30, 2011 at 12:41:05PM -0500, Pat Erley wrote:
> Having run into this same issue before, I considered adding some
> default values for the case that wmm is not configured, but someone
> tries to enable 802.11n, I just never decided where the best spot
> for that would be.  Should this sort of thing be a hostapd default
> or somewhere in the cfg80211/mac80211 layer?  I was thinking this
> should be something that hostapd does.
> 
> As I see it, there are a few ways to prevent this problem:
> 
> 1. Hostapd doesn't allow 802.11n to be enabled without wmm

I don't think that that would ever happen since as far as I can tell,
WMM is not required from 802.11n based on any standard or specification.
(Sure, there may be some non-IEEE certifications that require it, but
hostapd is not limited by such requirements; it just needs to allow one
to implement a device to meet such needs.)

> 2. Hostapd does allow 802.11n to be enabled without wmm, but uses
>    defaults

What do you mean with "defaults" here?

> 3. Hostapd doesn't care about this, and the kernel doesn't allow
>    802.11n without wmm

My comment on (1) would apply here.

> 4. Hostapd doesn't care, but the kernel makes the correnctions

I don't think that that would be a good idea either and well, not really
at all suitable for the current design of where the HT/WMM IEs come from
for management frames in AP mode.

> I believe 2 is the cleanest solution.  So that the packets passed
> from hostapd can make it through unmolested, and new hostapd versions
> can work with older kernels.  Any other solution I'm not thinking of?

I do not fully understand what (2) is, but it may be close enough to
what I think would be a reasonable approach:
- for non-AP STA case, allows association with HT even if WMM (or IEEE
  802.11 QoS) is not enabled (mac80211 change)
- for AP case, make hostapd default to enabling WMM with default EDCA
  parameters if HT is enabled and there is no explicit configuration
  for disabling WMM
- if WMM is explicitly disabled in hostapd.conf, allow IEEE 802.11n
  to be enabled without WMM/QoS

The main focus here is to make it less likely for users to end up
configuring something they did not plan on doing while not removing
flexibility in configuration. I don't know any particularly good reasons
for disabling WMM/QoS/aggregation, but that is not good enough
justification to make it impossible to do so.
 
-- 
Jouni Malinen                                            PGP id EFC895FA

      reply	other threads:[~2011-01-31 11:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-30  5:38 Why is wmm_param required for HT40- in mlme.c Ben Greear
2011-01-30  9:36 ` Johannes Berg
2011-01-30 17:34   ` Ben Greear
2011-01-31 11:03     ` Johannes Berg
2011-01-31 17:35       ` Ben Greear
2011-01-31 17:40         ` Johannes Berg
2011-01-30 17:41   ` Pat Erley
2011-01-31 11:28     ` Jouni Malinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110131112841.GA2628@jm.kir.nu \
    --to=j@w1.fi \
    --cc=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pat-lkml@erley.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).