From: "John W. Linville" <linville@tuxdriver.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: Vivek Natarajan <vnatarajan@atheros.com>,
Greg KH <greg@kroah.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] ath9k: Drain txq before sending a nullfunc frame.
Date: Fri, 4 Feb 2011 09:21:30 -0500 [thread overview]
Message-ID: <20110204142130.GB2539@tuxdriver.com> (raw)
In-Reply-To: <AANLkTinSy7tQDXrVo2AdRpyQ2dQvvaeoJEpYdK1YszfQ@mail.gmail.com>
On Thu, Feb 03, 2011 at 11:36:27PM -0800, Luis R. Rodriguez wrote:
> Adding Greg for real this time.
>
> Luis
>
> On Thu, Feb 3, 2011 at 11:36 PM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> > On Thu, Feb 3, 2011 at 10:23 PM, Vivek Natarajan <vnatarajan@atheros.com> wrote:
> >> In a highly noisy environment, a data frame which is queued before
> >> a nullfunc frame on a different hw queue may be sent over the air
> >> after the tx completion of nullfunc frame. This causes the station
> >> to enter power save and the AP to see the station as awake and
> >> continues to send the data traffic. Fix this by draining all tx
> >> queues before we send the null function frame with PM bit set.
> >>
> >> Signed-off-by: Vivek Natarajan <vnatarajan@atheros.com>
> >
> > Hm nice, this is a good example of one of those random not-so-critical
> > but still nice fixes which I wish would go to stable. John, Greg, any
> > qualms for such things to go to stable if they apply? It was my
> > impression we could send it, but I want to verify with both you guys
> > so neither we or John get bashed if we try to send it as a stable fix.
I think the feeling is that it is silly to mark something for stable if
it is not important enough to be sent as a fix for the current release.
The standard for being sent for the current release seems to
vary a bit between different maintainers, the particular release
(i.e. how grumpy is Linus), and the point of the release cycle (i.e.
loser at -rc1, tighter at -rc6). But for the most part, to go to the
current release it needs to fix a bug rather than adding a feature.
The strictest definitions of "bug" include crashes, data corrupters,
and some (or possibly all) regressions. As usual, judging bug
"worthiness" is a bit of a judgment call.
All that said, I think the question is what grey area exists for
something that arrives late in the current release cycle but that
might still be viewed as a (minor) bug fix?
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2011-02-04 14:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 6:23 [PATCH 1/2] ath9k: Drain txq before sending a nullfunc frame Vivek Natarajan
2011-02-04 6:24 ` [PATCH 2/2] mac80211: Fix a race on enabling power save Vivek Natarajan
2011-02-04 7:37 ` Luis R. Rodriguez
2011-02-04 9:26 ` Vivek Natarajan
2011-02-04 10:31 ` Johannes Berg
2011-02-04 7:36 ` [PATCH 1/2] ath9k: Drain txq before sending a nullfunc frame Luis R. Rodriguez
2011-02-04 7:36 ` Luis R. Rodriguez
2011-02-04 14:21 ` John W. Linville [this message]
2011-02-04 14:57 ` Greg KH
2011-02-04 8:28 ` Sujith
2011-02-04 9:17 ` Vivek Natarajan
2011-02-04 10:23 ` Sujith
2011-02-04 10:47 ` Vivek Natarajan
2011-02-04 11:07 ` Sujith
2011-02-09 19:06 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204142130.GB2539@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=vnatarajan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).