From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John W Linville <linville@tuxdriver.com>,
george0505@realtek.com, chaoming_li@realsil.com.cn,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/6] rtlwifi: rtl8192ce: Refactor rtl8192ce/fw
Date: Mon, 7 Feb 2011 16:08:58 +0100 [thread overview]
Message-ID: <20110207150857.GE2319@redhat.com> (raw)
In-Reply-To: <4d4eec0f.et2vL5g5GiBl8wXm%Larry.Finger@lwfinger.net>
On Sun, Feb 06, 2011 at 12:44:31PM -0600, Larry Finger wrote:
> +bool _rtl92c_cmd_send_packet(struct ieee80211_hw *hw,
> + struct sk_buff *skb)
> +{
> + struct rtl_priv *rtlpriv = rtl_priv(hw);
> + struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
> + struct rtl8192_tx_ring *ring;
> + struct rtl_tx_desc *pdesc;
> + u8 own;
> + unsigned long flags;
> + struct sk_buff *pskb = NULL;
> +
> + ring = &rtlpci->tx_ring[BEACON_QUEUE];
> +
> + pskb = __skb_dequeue(&ring->queue);
> + if (pskb)
> + kfree_skb(pskb);
> +
> + spin_lock_irqsave(&rtlpriv->locks.irq_th_lock, flags);
I think __skb_dequeue(&ring->queue) should be also protected
by lock.
prev parent reply other threads:[~2011-02-07 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 18:44 [PATCH 4/6] rtlwifi: rtl8192ce: Refactor rtl8192ce/fw Larry Finger
2011-02-07 15:08 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207150857.GE2319@redhat.com \
--to=sgruszka@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=george0505@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).