linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] wl12xx: change type from u8 to int
@ 2011-02-07 16:47 Dan Carpenter
  2011-02-23 13:52 ` Luciano Coelho
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-02-07 16:47 UTC (permalink / raw)
  To: Luciano Coelho, shahar_levi
  Cc: John W. Linville, linux-wireless, kernel-janitors

ret is used to store int types.  Using an u8 will break the error
handling.

Signed-off-by: Dan Carpenter <error27@gmail.com>

diff --git a/drivers/net/wireless/wl12xx/init.c b/drivers/net/wireless/wl12xx/init.c
index 70b3dc8..e430b2a 100644
--- a/drivers/net/wireless/wl12xx/init.c
+++ b/drivers/net/wireless/wl12xx/init.c
@@ -470,7 +470,7 @@ static void wl1271_check_ba_support(struct wl1271 *wl)
 static int wl1271_set_ba_policies(struct wl1271 *wl)
 {
 	u8 tid_index;
-	u8 ret = 0;
+	int ret = 0;
 
 	/* Reset the BA RX indicators */
 	wl->ba_rx_bitmap = 0;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-02-23 13:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-07 16:47 [patch] wl12xx: change type from u8 to int Dan Carpenter
2011-02-23 13:52 ` Luciano Coelho

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).