From: Stanislaw Gruszka <sgruszka@redhat.com>
To: wwguy <wey-yi.w.guy@intel.com>
Cc: Intel Linux Wireless <ilw@linux.intel.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 5/5] iwlwifi: avoid too frequent recover from statistics
Date: Wed, 9 Feb 2011 07:28:15 +0100 [thread overview]
Message-ID: <20110209062815.GC2184@redhat.com> (raw)
In-Reply-To: <1297179953.20613.38.camel@wwguy-ubuntu>
On Tue, Feb 08, 2011 at 07:45:53AM -0800, wwguy wrote:
> > - priv->plcp_jiffies = stamp;
> > -
> > - if (msecs == 0)
> > - return true;
> > + BUG_ON(msecs == 0);
>
> why not just return? I understand it should not be "0", but really need
> BUG_ON?
>
> >
> > - stamp = jiffies;
> > - msecs = jiffies_to_msecs(stamp - priv->plcp_jiffies);
> > - priv->plcp_jiffies = stamp;
> > -
> > - if (msecs == 0)
> > - return true;
> > + BUG_ON(msecs == 0);
> Same above
>
>
> Similar question, we are very close to finish driver split, when is the
> best time for this patch?
The same aswer :-) I will respin, when your patches will land in John tree.
Stanislaw
next prev parent reply other threads:[~2011-02-09 6:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 8:31 [PATCH 1/5] iwlwifi: cleanup iwl_recover_from_statistics Stanislaw Gruszka
2011-02-08 8:31 ` [PATCH 2/5] iwlwifi: cleanup {iwl,iwl3945}_good_plcp_health Stanislaw Gruszka
2011-02-08 15:24 ` wwguy
2011-02-09 6:24 ` Stanislaw Gruszka
2011-02-09 17:03 ` wwguy
2011-02-08 8:31 ` [PATCH 3/5] iwlwifi: cleanup iwl_good_ack_health Stanislaw Gruszka
2011-02-08 15:32 ` wwguy
2011-02-08 8:31 ` [PATCH 4/5] iwlwifi: fix ack health for WiFi/BT combo devices Stanislaw Gruszka
2011-02-08 15:36 ` wwguy
2011-02-09 6:26 ` Stanislaw Gruszka
2011-02-09 17:04 ` wwguy
2011-02-08 8:31 ` [PATCH 5/5] iwlwifi: avoid too frequent recover from statistics Stanislaw Gruszka
2011-02-08 15:45 ` wwguy
2011-02-09 6:28 ` Stanislaw Gruszka [this message]
2011-02-09 17:05 ` wwguy
2011-02-08 15:16 ` [PATCH 1/5] iwlwifi: cleanup iwl_recover_from_statistics wwguy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209062815.GC2184@redhat.com \
--to=sgruszka@redhat.com \
--cc=ilw@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).