From: Stanislav Fomichev <kernel@fomichev.me>
To: brudley@broadcom.com, gregkh@suse.de
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH] brcm80211: remove multiple calls to wl_release_fw
Date: Sat, 12 Feb 2011 18:00:33 +0300 [thread overview]
Message-ID: <20110212150033.GA1941@sdf-MacBook> (raw)
This causes an oops when the bcm43xx_hdr-0.fw binary is not found.
Signed-off-by: Stanislav Fomichev <s@fomichev.me>
---
drivers/staging/brcm80211/sys/wl_mac80211.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/brcm80211/sys/wl_mac80211.c b/drivers/staging/brcm80211/sys/wl_mac80211.c
index cd8392b..5faa521 100644
--- a/drivers/staging/brcm80211/sys/wl_mac80211.c
+++ b/drivers/staging/brcm80211/sys/wl_mac80211.c
@@ -1767,7 +1767,6 @@ static int wl_request_fw(struct wl_info *wl, struct pci_dev *pdev)
if (status) {
printf("%s: fail to load firmware %s\n",
KBUILD_MODNAME, fw_name);
- wl_release_fw(wl);
return status;
}
WL_NONE("request fw %s\n", fw_name);
@@ -1777,7 +1776,6 @@ static int wl_request_fw(struct wl_info *wl, struct pci_dev *pdev)
if (status) {
printf("%s: fail to load firmware %s\n",
KBUILD_MODNAME, fw_name);
- wl_release_fw(wl);
return status;
}
wl->fw.hdr_num_entries[i] =
--
1.7.1
next reply other threads:[~2011-02-12 15:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 15:00 Stanislav Fomichev [this message]
2011-02-14 19:59 ` [PATCH] brcm80211: remove multiple calls to wl_release_fw Roland Vossen
2011-02-14 20:22 ` Dan Carpenter
2011-02-14 20:40 ` Roland Vossen
2011-02-14 21:03 ` Stanislav Fomichev
2011-02-14 21:07 ` Stanislav Fomichev
2011-02-14 21:20 ` Dan Carpenter
2011-02-18 20:57 ` Greg KH
2011-02-19 9:03 ` Stanislav Fomichev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110212150033.GA1941@sdf-MacBook \
--to=kernel@fomichev.me \
--cc=brudley@broadcom.com \
--cc=gregkh@suse.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).