From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:48156 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877Ab1BNUPe (ORCPT ); Mon, 14 Feb 2011 15:15:34 -0500 Date: Mon, 14 Feb 2011 15:10:53 -0500 From: "John W. Linville" To: wwguy Cc: Johannes Berg , "linux-wireless@vger.kernel.org" , "ipw3945-devel@lists.sourceforge.net" Subject: Re: [PATCH 1/1] iwl3945: iwl3945_good_plcp_health might not used Message-ID: <20110214201052.GE2722@tuxdriver.com> References: <1297354593-22897-1-git-send-email-wey-yi.w.guy@intel.com> <1297677349.3785.3.camel@jlt3.sipsolutions.net> <1297697139.4723.4.camel@wwguy-ubuntu> <1297697334.3953.7.camel@jlt3.sipsolutions.net> <1297698486.4723.15.camel@wwguy-ubuntu> <1297698872.3953.8.camel@jlt3.sipsolutions.net> <1297699053.4723.17.camel@wwguy-ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1297699053.4723.17.camel@wwguy-ubuntu> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Feb 14, 2011 at 07:57:33AM -0800, wwguy wrote: > On Mon, 2011-02-14 at 07:54 -0800, Johannes Berg wrote: > > On Mon, 2011-02-14 at 07:48 -0800, wwguy wrote: > > > On Mon, 2011-02-14 at 07:28 -0800, Johannes Berg wrote: > > > > On Mon, 2011-02-14 at 07:25 -0800, wwguy wrote: > > > > > On Mon, 2011-02-14 at 01:55 -0800, Johannes Berg wrote: > > > > > > On Thu, 2011-02-10 at 08:16 -0800, Wey-Yi Guy wrote: > > > > > > > remove plcp check for 3945, mark the function __maybe_unused > > > > > > > > > > > > Why not remove the function instead? > > > > > > > > > > > I guess we can remove it in legacy driver > > > > > > > > But it's a 3945 specific function, and never used, so ...?? > > > > > > > I mean we should remove this function in legacy driver after driver > > > split > > > > I just don't see why we can't remove it right now? > > > we can do it for _stable, for mainstream, all 3945 will move to separate > driver anyway. ...where it will still be unused. No? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.