From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27006 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093Ab1BONGi (ORCPT ); Tue, 15 Feb 2011 08:06:38 -0500 Date: Tue, 15 Feb 2011 14:06:22 +0100 From: Stanislaw Gruszka To: Johannes Berg Cc: Wey-Yi Guy , Intel Linux Wireless , linux-wireless@vger.kernel.org Subject: Re: [PATCH] iwlwifi: zero fill txq->txb on queue reset Message-ID: <20110215130621.GB2515@redhat.com> References: <1297693999-15342-1-git-send-email-sgruszka@redhat.com> <1297695219.3953.5.camel@jlt3.sipsolutions.net> <1297695325.3953.6.camel@jlt3.sipsolutions.net> <20110215113951.GD2162@redhat.com> <1297770482.3935.1.camel@jlt3.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1297770482.3935.1.camel@jlt3.sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Feb 15, 2011 at 12:48:02PM +0100, Johannes Berg wrote: > On Tue, 2011-02-15 at 12:39 +0100, Stanislaw Gruszka wrote: > > > > > > if (txq_id == priv->cmd_queue) > > > > > actual_slots++; > > > > > + else > > > > > + memset(txq->txb, 0, sizeof(txq->txb[0]) * TFD_QUEUE_SIZE_MAX); > > > > > > > > I don't mind -- but I think the changelog should say that this isn't > > > > necessary since the device will never use any of those entries? > > > > > > Err, I confused txb and tfds. But it still shouldn't be necessary -- > > > aren't the entries reset to NULL when taken out of use? > > > > There are memset zero before the use in {iwlagn,iwl3945}_tx_skb(), > > so patch is unneeded as well kzalloc in current code (I add replace > > to kmalloc to my todo list). > > Well, don't worry, the change is fine -- hmm, I think is not, it just add more confusion Stanislaw